gettext: support non-ASCII msgids for Rust#12491
Closed
danielrainer wants to merge 1 commit intofish-shell:masterfrom
Closed
gettext: support non-ASCII msgids for Rust#12491danielrainer wants to merge 1 commit intofish-shell:masterfrom
danielrainer wants to merge 1 commit intofish-shell:masterfrom
Conversation
The `msguniq` call for deduplicating the msgids originating from Rust previously did not get a header entry (empty msgid with msgstr containing metadata). This works fine as long as all msgids are ASCII-only. But when a non-ASCII character appears in a msgid, `msguniq` errors out without a header specifying the encoding. To resolve this, add the header to the input of this `msguniq` invocation and then remove the header again using sed to prevent duplicating it for the outer msguniq call at the end of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
msguniqcall for deduplicating the msgids originating from Rust previously did not get a header entry (empty msgid with msgstr containing metadata). This works fine as long as all msgids are ASCII-only. But when a non-ASCII character appears in a msgid,msguniqerrors out without a header specifying the encoding. To resolve this, add the header to the input of thismsguniqinvocation and then remove the header again using sed to prevent duplicating it for the outer msguniq call at the end of the file.