fix: version test on shallow, dirty git repo#12498
Closed
danielrainer wants to merge 1 commit intofish-shell:masterfrom
Closed
fix: version test on shallow, dirty git repo#12498danielrainer wants to merge 1 commit intofish-shell:masterfrom
danielrainer wants to merge 1 commit intofish-shell:masterfrom
Conversation
In shallow, dirty git repo, the version identifier will look something like `fish, version 4.5.0-g971e0b7-dirty`, with no commit counter indicating the commits since the last version. Our regex did not handle this case. Make the commit counter optional, which also allows removing the second alternative in the regex, since it's now subsumed by the first. Fixes fish-shell#12497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In shallow, dirty git repo, the version identifier will look something like
fish, version 4.5.0-g971e0b7-dirty, with no commit counter indicating the commits since the last version. Our regex did not handle this case.Make the commit counter optional, which also allows removing the second alternative in the regex, since it's now subsumed by the first.
Fixes #12497