feat: port machine gun #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxCWhitehead
requested changes
Apr 4, 2024
Open
Collaborator
|
@DRuppFv It looks like the continuous integration found some issues with the formatting in Thank you! |
MaxCWhitehead
approved these changes
Apr 4, 2024
Collaborator
MaxCWhitehead
left a comment
There was a problem hiding this comment.
Thank you very much for your work here @DRuppFv :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #573.
I added
bullet_spreadsystem to the machine gun because I think it balances the game and looks good, and addedempty_cooldownbecause it would be really boring ifgun_empty.oggkept playing at the same frequency as the normal cooldown, so in this gun we have the shooting cooldown and the empty sound cooldown. I also made a very slight change in the main system for using items because it had to be able to shoot constantly, so now you can keep shoot input pressed with any weapon.Something I think is important to mention is that the shooting animation is synchronized to the rate of fire, so if you change the rate of fire the animation will also change. It could be easily changed with a new variable in the .yaml so let me know whether you think it should be faster or slower.
The machine gun has two states (idle and shooting) and its only function is to reset and start animations.