feat(CR-306): Add webhooks for line of credit facility updates #164
+664
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds webhook support for line of credit facility lifecycle events by implementing business event notifications and Avro serialization. The changes enable external systems to receive real-time notifications when line of credit facilities are created, approved, activated, closed, or modified.
Key changes include:
- Added 9 business event classes for different LOC state transitions (created, approved, activated, deactivated, closed, reactivated, increased, decreased, updated)
- Implemented Avro schema and serialization infrastructure for LOC data
- Integrated event notifications into LOC write service operations
- Added database migrations to configure external event handling
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ExternalEventSourceProviderConfig.java | Extended external event source configuration to include custom Crediblex event classes |
| LineOfCreditDataV1.avsc | Added Avro schema definition for line of credit data serialization |
| LineOfCreditWritePlatformServiceImpl.java | Integrated business event notifications into LOC lifecycle operations |
| LineOfCreditBusinessEventSerializer.java | Implemented serializer to convert LOC business events to Avro format |
| LineOfCreditV1Mapper.java | Created mapper to transform LOC domain objects to Avro DTOs |
| LineOfCreditBusinessEvent.java (and 8 event subclasses) | Defined business event hierarchy for LOC operations |
| dependencies.gradle | Added dependencies for Avro schemas and serialization |
| 0044-add-loc-events-in-external-event-configuration-table.xml | Database migration to register LOC events in external event configuration |
| 0045-add-missing-event-in-event-configuration-table.xml | Database migration to add SavingsToLoanAccountTransferBusinessEvent configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...t/portfolio/loc/infrastructure/event/external/serialization/mapper/LineOfCreditV1Mapper.java
Show resolved
Hide resolved
...c/main/resources/db/custom-changelog/0045-add-missing-event-in-event-configuration-table.xml
Show resolved
Hide resolved
oluexpert99
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.