[CRED-331] Allow Early Repayment / Prepayment Before First Installmen… #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Due Date for RBF Loans
There was a problem hiding this comment.
Pull request overview
This PR enables early repayment/prepayment before the first installment due date for all loan types, not just drawdown loans (RBF loans). The change simplifies the logic by treating all loans uniformly for early repayment scenarios.
Key changes:
- Modified installment resolution logic to find the first unpaid installment for early repayments
- Removed the drawdown loan check by setting
isDrawdownLoanto alwaystrue - Added comprehensive test coverage for sequential early repayments and edge cases
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CredibleXLoanPenaltyCalculator.java | Enhanced resolveInstallmentByTransactionDate and getInterestDueForTransaction methods to properly handle early repayments by skipping PAID installments and finding the first unpaid installment |
| CustomLoanWritePlatformServiceJpaRepositoryImpl.java | Simplified logic by hardcoding isDrawdownLoan to true to enable early repayment for all loan types |
| CredXLoanReadPlatformServiceImpl.java | Applied same simplification as CustomLoanWritePlatformServiceJpaRepositoryImpl.java for consistency |
| CredibleXLoanPenaltyCalculatorTest.java | Added three comprehensive test cases covering sequential early repayments, multiple installments, and repayment before first due date |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...java/com/crediblex/fineract/portfolio/loanaccount/domain/CredibleXLoanPenaltyCalculator.java
Outdated
Show resolved
Hide resolved
...java/com/crediblex/fineract/portfolio/loanaccount/domain/CredibleXLoanPenaltyCalculator.java
Outdated
Show resolved
Hide resolved
…t Due Date for RBF Loans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t Due Date for RBF Loans
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.