Set blondie backend to default. #405
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Oct 20, 2025
src/lib.rs
Outdated
| { | ||
| let mut help_test = crate::arch::base_dtrace_command(None); | ||
|
|
||
| let if_dtrace_enabled = std::env::var("DTRACE").is_ok(); |
There was a problem hiding this comment.
This layers a bunch of stuff on top which is not the best approach. Should probably rework the initial_command() function to do something like this:
match (workload, env::var("DTRACE")) {
#[cfg(target_os = "windows")]
(Workload::Command(c), Err(_)) => // do blondie
#[cfg(not(target_os = "windows"))]
(Workload::Command(c), Err(_)) => // dtrace on path fallback
(Workload::Command(c), Ok(dtrace) => // do dtrace
_ => // do dtrace
}There was a problem hiding this comment.
Ooops.Accidentally click the resolve.
|
As the fallback to PATH is in the base_dtrace_command ,if change there will be a lot of changes, I didn't change it. |
|
This set of changes makes no sense. It really needs some rethinking of the structure of the code. If you don't have the time/experience to do this, better to just close it. I don't want to do it myself since I don't have access to a Windows environment which makes testing a pain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.