frontend/pages/hosts/ManageHostsPage/ManageHostsPage.tsx (1)

1567-1685: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Export uses stale localStorage for hidden columns, ignoring server-persisted user settings

Lines 1571–1592 read hidden columns from localStorage.getItem("hostHiddenColumns"). The migration block at lines 641–662 removes that key after successfully syncing to the server (localStorage.removeItem("hostHiddenColumns")). For any user who has been migrated, this read returns null, so currentHiddenColumns stays [] and generateVisibleTableColumns is called with hiddenColumns: [] — treating every column as visible regardless of the user's actual preferences. The exported CSV will include all columns instead of only the ones the user has enabled.

The hiddenColumns state variable is already the correct source of truth (initialized from userSettings?.hidden_host_columns and kept in sync by onSaveColumns). It should be used directly, and added to the dependency array.

🐛 Proposed fix

-    const hiddenColumnsStorage = localStorage.getItem("hostHiddenColumns");
-    let currentHiddenColumns = [];
-    let visibleColumns;
-    if (hiddenColumnsStorage) {
-      currentHiddenColumns = JSON.parse(hiddenColumnsStorage);
-    }
+    let visibleColumns;

     if (config && currentUser) {
       const tableColumns = generateVisibleTableColumns({
-        hiddenColumns: currentHiddenColumns,
+        hiddenColumns,
         isFreeTier,
         isOnlyObserver,
         teamId: teamIdForApi,
       });

Add hiddenColumns to the dependency array:

   }, [
     config,
     currentUser,
+    hiddenColumns,
     isFreeTier,
     isOnlyObserver,
     teamIdForApi,
     // ... rest of deps unchanged
   ]);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@frontend/pages/hosts/ManageHostsPage/ManageHostsPage.tsx` around lines 1567 -
1685, The export handler onExportHostsResults incorrectly reads hidden columns
from localStorage ("hostHiddenColumns") causing migrated users to get stale []
instead of their server-synced settings; instead, use the component state
hiddenColumns (which is initialized from userSettings?.hidden_host_columns and
updated by onSaveColumns) when calling generateVisibleTableColumns and remove
the localStorage.getItem fallback logic, and add hiddenColumns to the
useCallback dependency array so exports reflect current column visibility.