Thanks to visit codestin.com
Credit goes to github.com

Skip to content

v1: replace :::note by Note: for mkdocs#5402

Merged
FeodorFitsner merged 3 commits intov1from
v1-xx
Jun 26, 2025
Merged

v1: replace :::note by Note: for mkdocs#5402
FeodorFitsner merged 3 commits intov1from
v1-xx

Conversation

@ndonkoHenri
Copy link
Contributor

@ndonkoHenri ndonkoHenri commented Jun 25, 2025

With :::note, mkdocs thinks it is supposed to import a package/class, thereby failing to build+deploy.
Needed for flet-charts/MatplotlibChart, which inherits from Container.

Summary by Sourcery

Standardize internal type representation and update docstrings

Enhancements:

  • Replace public type fields with private _type in dataclass models for shapes, gradients, painting, borders, and controls
  • Update parsing functions to use _type and introduce default fallback for gradient parsing
  • Refactor assertion formatting in CupertinoDatePicker for consistent style

Documentation:

  • Convert mkdocs :::note and :::info admonitions to inline Note: and Info: blocks in docstrings

`date_picker_mode=CupertinoDatePickerMode.MONTH_YEAR`,
both `CupertinoDatePickerDateOrder.DAY_MONTH_YEAR` and
`CupertinoDatePickerDateOrder.MONTH_DAY_YEAR` will result in the month|year order.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to use Docusaurus for built-in docs and while this works for mkdocs (which we are not yet decided to to use for built-in docs for now) it will break a note in Docusaurus.

@FeodorFitsner FeodorFitsner merged commit f76d1c5 into v1 Jun 26, 2025
2 checks passed
@FeodorFitsner FeodorFitsner deleted the v1-xx branch June 26, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants