Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update elevated_button.py#5410

Merged
FeodorFitsner merged 2 commits intomainfrom
inesa/filled-button-bgcolor
Jul 1, 2025
Merged

Update elevated_button.py#5410
FeodorFitsner merged 2 commits intomainfrom
inesa/filled-button-bgcolor

Conversation

@InesaFitsner
Copy link
Contributor

@InesaFitsner InesaFitsner commented Jun 30, 2025

Description

Fixes #5404

Test Code

# Test code for the review of this PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I signed the CLA.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • I have made corresponding changes to the documentation (if applicable)

Screenshots

Additional details

Summary by Sourcery

Bug Fixes:

  • Ensure ElevatedButton applies color, bgcolor, and elevation properties by initializing a default ButtonStyle when style is not set

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@FeodorFitsner FeodorFitsner merged commit 051fce0 into main Jul 1, 2025
2 checks passed
@FeodorFitsner FeodorFitsner deleted the inesa/filled-button-bgcolor branch July 1, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1: FilledButton.bgcolor does not have effect

2 participants