Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed integration tests: Remove tester service from page initialization#5618

Merged
FeodorFitsner merged 1 commit intomainfrom
v1-fix-tests
Sep 3, 2025
Merged

Fixed integration tests: Remove tester service from page initialization#5618
FeodorFitsner merged 1 commit intomainfrom
v1-fix-tests

Conversation

@FeodorFitsner
Copy link
Contributor

@FeodorFitsner FeodorFitsner commented Sep 3, 2025

Eliminated appending the Tester service to the page's services list in FletTestApp. This may be part of a refactor or cleanup to simplify test app setup.

Summary by Sourcery

Eliminate automatic registration of the Tester service in FletTestApp to simplify test app setup and resolve integration test failures.

Bug Fixes:

  • Remove the page.services.append(self.__tester) call to prevent unwanted service injection during page initialization.

Enhancements:

  • Simplify FletTestApp.start by no longer appending the Tester service to the page’s services list.

Eliminated appending the Tester service to the page's services list in FletTestApp. This may be part of a refactor or cleanup to simplify test app setup.
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@cloudflare-workers-and-pages
Copy link

Deploying flet-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 08e8366
Status: ✅  Deploy successful!
Preview URL: https://f16feff6.flet-docs.pages.dev
Branch Preview URL: https://v1-fix-tests.flet-docs.pages.dev

View logs

@FeodorFitsner FeodorFitsner merged commit 441d828 into main Sep 3, 2025
5 of 6 checks passed
@FeodorFitsner FeodorFitsner deleted the v1-fix-tests branch September 3, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant