Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: BottomAppBar.border_radius property#5743

Merged
FeodorFitsner merged 5 commits intomainfrom
bottom-appbar-radius
Oct 28, 2025
Merged

feat: BottomAppBar.border_radius property#5743
FeodorFitsner merged 5 commits intomainfrom
bottom-appbar-radius

Conversation

@ndonkoHenri
Copy link
Contributor

@ndonkoHenri ndonkoHenri commented Oct 24, 2025 •
edited by sourcery-ai bot
Loading

Fix #4322

Example Code

import flet as ft


def main(page: ft.Page):
    page.vertical_alignment = ft.MainAxisAlignment.CENTER
    page.horizontal_alignment = ft.CrossAxisAlignment.CENTER

    page.bottom_appbar = ft.BottomAppBar(
        border_radius=ft.BorderRadius.all(20),
        bgcolor=ft.Colors.BLUE,
        content=ft.Row(
            controls=[
                ft.IconButton(icon=ft.Icons.MENU, icon_color=ft.Colors.WHITE),
                ft.Container(expand=True),
                ft.IconButton(icon=ft.Icons.SEARCH, icon_color=ft.Colors.WHITE),
                ft.IconButton(icon=ft.Icons.FAVORITE, icon_color=ft.Colors.WHITE),
            ]
        ),
    )

    page.add(ft.Text("Content goes here..."))


ft.run(main)

Summary by Sourcery

Enable custom border radius on BottomAppBar by introducing a new property, updating rendering logic in both Python and Dart components, and enhancing documentation and default value descriptions.

New Features:

  • Add border_radius property to BottomAppBar with automatic clipping support

Enhancements:

  • Standardize default fallback descriptions for BottomAppBar properties (bgcolor, shadow_color, padding, clip_behavior, shape, elevation)
  • Adjust clip behavior logic in Dart renderer to respect border_radius settings
  • Refine FloatingActionButton docstrings to use consistent error messages for negative values

Documentation:

  • Add a custom border radius example and image to BottomAppBar documentation

Copilot AI reviewed Oct 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a border_radius property to the BottomAppBar control, allowing developers to customize the corner rounding of the bottom app bar. The implementation also updates documentation formatting and error messages for consistency.

  • Added border_radius property to BottomAppBar with corresponding Python and Dart implementations
  • Updated clip_behavior to automatically default to ANTI_ALIAS when border radius is applied
  • Improved documentation strings across multiple properties for clarity and consistency

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/python/packages/flet/src/flet/controls/material/bottom_app_bar.py Added border_radius property, updated property documentation, and modified clip_behavior default behavior
packages/flet/lib/src/controls/bottom_app_bar.dart Implemented border radius rendering using ClipRRect wrapper with automatic clip behavior handling
sdk/python/examples/controls/bottom_app_bar/border_radius.py Added example demonstrating the new border_radius property usage
sdk/python/packages/flet/docs/controls/bottomappbar.md Added documentation section for custom border radius feature
sdk/python/packages/flet/src/flet/controls/material/floating_action_button.py Standardized error message formatting in documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

sourcery-ai[bot]
sourcery-ai bot reviewed Oct 24, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2025 •
edited
Loading

Deploying flet-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 953181d
Status: ✅  Deploy successful!
Preview URL: https://f3108d13.flet-docs.pages.dev
Branch Preview URL: https://bottom-appbar-radius.flet-docs.pages.dev

View logs

@FeodorFitsner
Copy link
Contributor

FeodorFitsner commented Oct 24, 2025

Example screenshot must be generated with integration test. See example here: packages/flet/integration_tests/examples/material/test_bottom_app_bar.py
You will probably need to set window size like, for example, in this test: packages/flet/integration_tests/examples/material/test_bottom_sheet.py

@FeodorFitsner
Copy link
Contributor

FeodorFitsner commented Oct 28, 2025

I'd display "image for docs" here with 50% width (as in other controls): https://0b45a5ba.flet-docs.pages.dev/controls/bottomappbar/

FeodorFitsner
FeodorFitsner reviewed Oct 28, 2025
View reviewed changes
@FeodorFitsner FeodorFitsner merged commit 08b5377 into main Oct 28, 2025
23 of 37 checks passed
@FeodorFitsner FeodorFitsner deleted the bottom-appbar-radius branch October 28, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FeodorFitsner FeodorFitsner FeodorFitsner approved these changes

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make it possible to change BottomAppBar's border radius

3 participants

@ndonkoHenri @FeodorFitsner