Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disable Rive in desktop client light#6032

Merged
FeodorFitsner merged 3 commits intomainfrom
disable-rive-in-desktop-light
Jan 19, 2026
Merged

Disable Rive in desktop client light#6032
FeodorFitsner merged 3 commits intomainfrom
disable-rive-in-desktop-light

Conversation

@FeodorFitsner
Copy link
Contributor

@FeodorFitsner FeodorFitsner commented Jan 19, 2026

Summary by Sourcery

Gate the Rive extension and dependency behind the fat desktop client configuration and improve Python package version patching.

Bug Fixes:

  • Restrict the Rive Flutter extension and dependency so they are only included in the fat desktop client build, effectively disabling Rive for the light desktop client.

Enhancements:

  • Update the Python packaging version patch script to also populate generic version fields alongside flet_version.

Build:

  • Adjust Dart imports and extension registration to align Rive and media extensions with the fat client build guards.
  • Move the flet_rive dependency into the fat client section of the Flutter pubspec.yaml so it is only pulled in for fat desktop builds.

Changed CI workflow runners from Ubuntu 24.04 to 22.04 for both ARM64 and AMD64 jobs. Updated common.sh to patch empty version strings in Python package version files.
Installs software-properties-common, adds the universe repository, and installs libunwind-dev in the CI workflow to ensure required dependencies are available for builds.
Switched CI workflow runners to Ubuntu 24.04 for both ARM64 and AMD64, and removed unnecessary apt repository and package installations. Refactored the integration of the Rive extension in main.dart and pubspec.yaml to be consistently wrapped with FAT_CLIENT markers, improving maintainability and clarity.
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@FeodorFitsner FeodorFitsner merged commit f617e93 into main Jan 19, 2026
34 of 52 checks passed
@FeodorFitsner FeodorFitsner deleted the disable-rive-in-desktop-light branch January 19, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant