Fix route pushing by converting route to string#6156
Closed
tct123 wants to merge 1 commit intoflet-dev:mainfrom
Closed
Fix route pushing by converting route to string#6156tct123 wants to merge 1 commit intoflet-dev:mainfrom
tct123 wants to merge 1 commit intoflet-dev:mainfrom
Conversation
Contributor
|
Is there an error without that fix? |
Contributor
Author
|
Pyright gave an error. It required this to be a string. |
FeodorFitsner
added a commit
that referenced
this pull request
Feb 12, 2026
Change the type annotation of View.route from Optional[str] to str while keeping the default value of "/". This simplifies usage by ensuring View.route is always a string (no Optional checks required) since a default route is provided. Close #6156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test Code
Type of change
Checklist
Screenshots
Additional details
Summary by Sourcery
Bug Fixes: