Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix route pushing by converting route to string#6156

Closed
tct123 wants to merge 1 commit intoflet-dev:mainfrom
tct123:patch-1
Closed

Fix route pushing by converting route to string#6156
tct123 wants to merge 1 commit intoflet-dev:mainfrom
tct123:patch-1

Conversation

@tct123
Copy link
Contributor

@tct123 tct123 commented Feb 11, 2026

Description

Test Code

# Test code for the review of this PR
# code in file

Type of change

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I signed the CLA.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • I have made corresponding changes to the documentation (if applicable)

Screenshots

Additional details

Summary by Sourcery

Bug Fixes:

  • Fix view pop handler to push the current view route as a string to prevent routing errors.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@FeodorFitsner
Copy link
Contributor

Is there an error without that fix?

@tct123
Copy link
Contributor Author

tct123 commented Feb 11, 2026

Pyright gave an error. It required this to be a string.

FeodorFitsner added a commit that referenced this pull request Feb 12, 2026
Change the type annotation of View.route from Optional[str] to str while keeping the default value of "/". This simplifies usage by ensuring View.route is always a string (no Optional checks required) since a default route is provided.

Close #6156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants