fix(storage): return service properties XML - #144
Merged
hectorvent merged 1 commit intoJul 31, 2026
Conversation
|
| Filename | Overview |
|---|---|
| src/main/java/io/floci/az/services/blob/BlobServiceHandler.java | Switches service-properties XML terminal call from toString() to build() so the response body is accumulated XML. |
| src/main/java/io/floci/az/services/queue/QueueServiceHandler.java | Same XmlBuilder.build() fix for queue service properties. |
| src/main/java/io/floci/az/services/table/TableServiceHandler.java | Adds account-root service-properties routing and XmlBuilder-based GET response consistent with blob/queue. |
| src/test/java/io/floci/az/services/BlobServiceTest.java | Integration test for blob service properties XML and regression guard against XmlBuilder@. |
| src/test/java/io/floci/az/services/QueueServiceTest.java | Integration test for queue service properties XML and regression guard against XmlBuilder@. |
| src/test/java/io/floci/az/services/TableServiceTest.java | New Quarkus test covering table account service-properties GET returning StorageServiceProperties XML. |
Reviews (1): Last reviewed commit: "fix(storage): return service properties ..." | Re-trigger Greptile
hectorvent
approved these changes
Jul 31, 2026
7 tasks
hectorvent
added a commit
that referenced
this pull request
Jul 31, 2026
…#144 (#152) PRs #133 and #144 both added getBlobServicePropertiesReturnsXml and getQueueServicePropertiesReturnsXml; the merges were textually clean but left duplicate methods, breaking test compilation on main since aa3e378. Each pair is now one method carrying both copies' assertions (XML structure from #144, the StaticWebsite element and XmlBuilder@ toString regression guard from #133).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StorageServicePropertiesXML for Blob and Queue storage instead of theXmlBuilder@...object identity string.?restype=service&comp=propertiesrequests to an Azure-compatible XML response.Closes #131
Closes #132
Type of change
fix:)feat:)feat!:orfix!:)Azure Compatibility
Azure Storage clients expect
StorageServicePropertiesXML for account-rootrestype=service&comp=propertiesrequests. Blob and Queue previously returned the builder object's identity string, while Table returned list-table JSON. This change returns the expected XML response shape for all three storage services.Checklist
./mvnw testpasses locally on JDK 25