Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dockerfile: Enable default SIMD support in Docker (#10215) #10225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dockerfile: Enable default SIMD support in Docker (#10215) #10225

wants to merge 1 commit into from
+14 −2

Conversation

jinyongchoi
Copy link
Contributor

@jinyongchoi jinyongchoi commented Apr 17, 2025 •
edited
Loading

According to the documentation,
SIMD is supposed to be enabled by default in Fluent Bit container images.

This commit updates the Dockerfile to reflect that, enabling SIMD by default.

Closes #10215

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@jinyongchoi jinyongchoi force-pushed the 10215-enable_simd_in_container branch 2 times, most recently from 12620cb to 06d8967 Compare April 17, 2025 10:46
@jinyongchoi
Copy link
Contributor Author

I think it makes sense to wait until this ticket(#10178) is completed before proceeding.
I’ll hold off for now.

@cdancy
Copy link

cdancy commented Apr 29, 2025

@jinyongchoi looks like those PR's were merged. Can we move forward here as we'd love to have a boost in json processing as well.

@jinyongchoi jinyongchoi force-pushed the 10215-enable_simd_in_container branch from 3a7abc0 to 662ba6b Compare April 30, 2025 07:14
@jinyongchoi jinyongchoi force-pushed the 10215-enable_simd_in_container branch from 662ba6b to 3d5e883 Compare April 30, 2025 07:16
@jinyongchoi jinyongchoi force-pushed the 10215-enable_simd_in_container branch from 3d5e883 to ed5d9e0 Compare April 30, 2025 12:36
@jinyongchoi jinyongchoi force-pushed the 10215-enable_simd_in_container branch from ed5d9e0 to 07b6cac Compare April 30, 2025 12:53
@jinyongchoi
Copy link
Contributor Author

@patrick-stephens @cdancy Hello,
I've enabled the FLB_SIMD option by default in all Dockerfiles except for Dockerfile.centos7,
which is used for internal testing.
If the SIMD option should also be enabled there, please let me know and I’ll update it accordingly.
Thank you!

@patrick-stephens
Copy link
Contributor

@patrick-stephens @cdancy Hello,
I've enabled the FLB_SIMD option by default in all Dockerfiles except for Dockerfile.centos7,
which is used for internal testing.
If the SIMD option should also be enabled there, please let me know and I’ll update it accordingly.
Thank you!

I would as it's intended to verify Centos 7 builds and you've enabled it for the actual builds themselves I think

@patrick-stephens patrick-stephens added ok-package-test Run PR packaging tests and removed docs-required labels Apr 30, 2025
@jinyongchoi
dockerfile: Enable default SIMD support in Docker (fluent#10215)
e487541 
According to the documentation,
SIMD is supposed to be enabled by default in Fluent Bit container images.

This commit updates the Dockerfile to reflect that, enabling SIMD by default.

Signed-off-by: jinyong.choi <[email protected]>
@jinyongchoi jinyongchoi force-pushed the 10215-enable_simd_in_container branch from 07b6cac to e487541 Compare April 30, 2025 16:49
@jinyongchoi
Copy link
Contributor Author

@patrick-stephens @cdancy Hello,
I've enabled the FLB_SIMD option by default in all Dockerfiles except for Dockerfile.centos7,
which is used for internal testing.
If the SIMD option should also be enabled there, please let me know and I’ll update it accordingly.
Thank you!

I would as it's intended to verify Centos 7 builds and you've enabled it for the actual builds themselves I think

I've updated Dockerfile.centos7 to include the SIMD option as suggested.
Please let me know if there's anything else you'd like me to adjust.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niedbalski niedbalski Awaiting requested review from niedbalski niedbalski is a code owner

@patrick-stephens patrick-stephens Awaiting requested review from patrick-stephens patrick-stephens is a code owner

@celalettin1286 celalettin1286 Awaiting requested review from celalettin1286 celalettin1286 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ok-package-test Run PR packaging tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using SIMD in a Fluent Bit Container
3 participants
@jinyongchoi @cdancy @patrick-stephens