-
Notifications
You must be signed in to change notification settings - Fork 729
Remove SpacesPerIndentionLevel
#2281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SpacesPerIndentionLevel
#2281
Conversation
Qodana for .NET4 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
I would at least mention that you removed the property and why. There might be somebody that was relying on it (incorrectly) and then wondering why, while upgrading to v7, his code doesn't compile anymore... |
Pull Request Test Coverage Report for Build 6132291253
💛 - Coveralls |
12bf479
to
ed05143
Compare
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
SpacesPerIndentionLevel
was added in #1295 but #1469 stopped using it.Both these PRs where while making v6, so
SpacesPerIndentionLevel
has never worked in any released version of Fluent Assertions.Not sure what to put in the release notes (if anything) 🤔
This fixes #2197
IMPORTANT
./build.sh --target spellcheck
or.\build.ps1 --target spellcheck
before pushing and check the good outcome