Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jnyrup
Copy link
Member

@jnyrup jnyrup commented Aug 27, 2023

SpacesPerIndentionLevel was added in #1295 but #1469 stopped using it.
Both these PRs where while making v6, so SpacesPerIndentionLevel has never worked in any released version of Fluent Assertions.

Not sure what to put in the release notes (if anything) 🤔

This fixes #2197

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

Qodana for .NET

4 new problems were found

Inspection name Severity Problems
Use preferred body style (convert into property, indexer, or event with preferred body style) ◽️ Notice 3
Loop can be converted into LINQ-expression ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@dennisdoomen
Copy link
Member

Not sure what to put in the release notes (if anything) 🤔

I would at least mention that you removed the property and why. There might be somebody that was relying on it (incorrectly) and then wondering why, while upgrading to v7, his code doesn't compile anymore...

@coveralls
Copy link

coveralls commented Aug 27, 2023

Pull Request Test Coverage Report for Build 6132291253

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 97.258%

Totals Coverage Status
Change from base Build 6131460438: 0.006%
Covered Lines: 11639
Relevant Lines: 11844

💛 - Coveralls

@jnyrup jnyrup force-pushed the SpacesPerIndentionLevel branch from 12bf479 to ed05143 Compare September 9, 2023 17:28
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@jnyrup jnyrup requested a review from dennisdoomen September 9, 2023 17:56
@jnyrup jnyrup merged commit 8007f03 into fluentassertions:develop Sep 11, 2023
@jnyrup jnyrup deleted the SpacesPerIndentionLevel branch September 11, 2023 17:55
This was referenced Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpacesPerIndentionLevel is not respected
3 participants