Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow excluding properties by name anywhere in the graph #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

Allow excluding properties by name anywhere in the graph #3062

merged 1 commit into from
Jun 21, 2025

Conversation

dennisdoomen
Copy link
Member

Adds a new convenience option

  subject.Should().BeEquivalentTo(expectation, options => options
      .ExcludingMembersNamed("LastName", "Age"));

Closes #3052

@dennisdoomen dennisdoomen force-pushed the exclude-member-names branch 2 times, most recently from 94d677c to 3fb431a Compare June 20, 2025 16:53
@dennisdoomen dennisdoomen added this to the 8.4.0 milestone Jun 20, 2025
@dennisdoomen dennisdoomen requested a review from jnyrup June 20, 2025 16:53
@coveralls
Copy link

coveralls commented Jun 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15795321345

Details

  • 10 of 11 (90.91%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 97.318%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Src/FluentAssertions/Equivalency/Selection/ExcludeMembersByNameSelectionRule.cs 6 7 85.71%
Totals Coverage Status
Change from base Build 15688110287: -0.004%
Covered Lines: 12469
Relevant Lines: 12668
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2025 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

jnyrup
jnyrup reviewed Jun 20, 2025
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Would be nice with an example in the docs.

@dennisdoomen
Copy link
Member Author

Would be nice with an example in the docs.

Just did.

@dennisdoomen dennisdoomen requested a review from jnyrup June 21, 2025 07:08
@jnyrup
Copy link
Member

jnyrup commented Jun 21, 2025

Are you missing a git push or is github playing tricks on me?

@dennisdoomen dennisdoomen force-pushed the exclude-member-names branch from 3fb431a to a88aec5 Compare June 21, 2025 11:36
@dennisdoomen dennisdoomen force-pushed the exclude-member-names branch from a88aec5 to 5cb24e9 Compare June 21, 2025 11:37
@dennisdoomen
Copy link
Member Author

Are you missing a git push or is github playing tricks on me?

Kind of, my push got rejected because of a mistake on my side... 🤦🏻

@dennisdoomen dennisdoomen merged commit 7928d55 into fluentassertions:main Jun 21, 2025
8 checks passed
@dennisdoomen dennisdoomen deleted the exclude-member-names branch June 28, 2025 06:02
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 15, 2025
Open
Merged
Closed
Open
Closed
Closed
Closed
Open
Closed
Open
Open
Open
Closed
Closed
Merged
Merged
Open
Open
Merged
Closed
Open
This was referenced Sep 22, 2025
Open
Closed
Closed
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnyrup jnyrup jnyrup approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: ExcludingMemberNames shortcut for BeEquivalentTo
3 participants
@dennisdoomen @coveralls @jnyrup