Inject a GetFilesChanged shim instead of using GithubService directly.#4178
Merged
auto-submit[bot] merged 7 commits intoflutter:mainfrom Jan 25, 2025
Merged
Inject a GetFilesChanged shim instead of using GithubService directly.#4178auto-submit[bot] merged 7 commits intoflutter:mainfrom
GetFilesChanged shim instead of using GithubService directly.#4178auto-submit[bot] merged 7 commits intoflutter:mainfrom
Conversation
jtmcdole
reviewed
Jan 25, 2025
| switch (filesChanged) { | ||
| case InconclusiveFilesChanged(:final pullRequestNumber, :final reason): | ||
| log.info('Running all targets on PR#$pullRequestNumber: $reason'); | ||
| return targets.toList(); |
jtmcdole
approved these changes
Jan 25, 2025
jtmcdole
approved these changes
Jan 25, 2025
Contributor
Author
|
@yjbanov I am going to submit this to unblock Part 2 Monday, but if you have any feedback or suggestions leave them and I'll send a follow-up PR. Thanks again! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards flutter/flutter#161462, towards flutter/flutter#162201.
This PR does a few things:
GetFilesChangedInconclusiveFilesChangedGithubApiGetFilesChangedThe intention is no user-facing behavioral changes, but this PR enables:
CheckRunArtifactsGetFilesChanged)