[Property Editor] Handle deprecated widget arguments#9062
Merged
elliette merged 3 commits intoflutter:masterfrom Mar 25, 2025
Merged
[Property Editor] Handle deprecated widget arguments#9062elliette merged 3 commits intoflutter:masterfrom
elliette merged 3 commits intoflutter:masterfrom
Conversation
| } | ||
| } | ||
|
|
||
| bool notDeprecatedWithNoValue(EditableArgument argument) => |
Member
There was a problem hiding this comment.
nit: consider making this function phrased in the positive deprecatedAndNotSet and then negate it where you call the method. I think this would make it easier to read rather than having to mentally parse the negatives.
Member
There was a problem hiding this comment.
It actually seems like the case we want to check for is deprecatedAndSet right? and then we only include properties that are either not deprecated or deprecatedAndSet?
Member
Author
There was a problem hiding this comment.
Haha yeah, I removed this method and just added the filter condition inline to where we actually filter out the deprecated properties. I think with a comment this is more clear than trying to come up with a descriptive method name:
// Filter out any deprecated properties that aren't set.
.where((property) => !property.isDeprecated || property.hasArgument)
kenzieschmoll
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8930