[Property Editor] Use the widget's starting position to create the key for the Property Editor#9087
Merged
elliette merged 4 commits intoflutter:masterfrom Apr 2, 2025
Merged
Conversation
kenzieschmoll
approved these changes
Apr 1, 2025
kenzieschmoll
approved these changes
Apr 1, 2025
|
autosubmit label was removed for flutter/devtools/9087, because - The status or check suite Verify PR Release Note Requirements has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This was referenced Apr 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #9031, #9035, #1948
In #8945, we added a
keyto the Property Editor inputs to determine whether or not to rebuild them in order to fix text field state retention issues.The problem with this approach is that the property inputs completely rebuild when the property is edited, which means if you hit "enter" after editing a value in the text field, the focus is lost (see second bullet point in #9031).
This PR instead creates the input
keyusing the location of the widget (along with other information) to determine whether the property is the same or not. Thevalueis then updated with theTextEditingController.Note: Requires this change in the Analysis Server to have a non-null
rangeand therefore fix the focus issue. I've tested with both the Analysis Server change and without. Without the Analysis Server change the behavior is the same as it currently is (where hitting "enter" causes the input to lose focus). I would like to submit this now since we are close to the stable cut-off, and then once the required change is in the Flutter SDK we can update the Flutter SDK version in DevTools.