Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixes future warning for awaiting Future returns in async bodies inside try blocks#9664

Merged
kenzieschmoll merged 2 commits intoflutter:masterfrom
FMorschel:await
Feb 27, 2026
Merged

Fixes future warning for awaiting Future returns in async bodies inside try blocks#9664
kenzieschmoll merged 2 commits intoflutter:masterfrom
FMorschel:await

Conversation

@FMorschel
Copy link
Contributor

@FMorschel FMorschel commented Feb 12, 2026

This is merely an analyzer change to avoid the bug explained at:

This will allow the development of a warning about these situations so we can avoid this bug in the future.

I'm not sure my changes fall into this category:

Please add a note to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md if your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

@FMorschel FMorschel mentioned this pull request Feb 12, 2026
Open
@FMorschel
Copy link
Contributor Author

FMorschel commented Feb 26, 2026 •
edited
Loading

Can I get any reviews here, please, @kenzieschmoll? This needs to land so I can then send a PR to flutter/tests and finally work on wrapping my change on the Dart SDK to avoid this problem.

Thanks a lot!

@FMorschel
Copy link
Contributor Author

FMorschel commented Feb 26, 2026 •
edited
Loading

Do I need to do anything about https://github.com/flutter/devtools/actions/runs/22336272555/job/65029549692?pr=9664?

CC @bkonyi, could you review this too, please (I forgot to ping you on the previous comment)? Thanks a lot!

@kenzieschmoll
Copy link
Member

kenzieschmoll commented Feb 26, 2026

CC @elliette for failing benchmark test

@elliette
Copy link
Member

elliette commented Feb 26, 2026

CC @elliette for failing benchmark test

Thanks! Investigating benchmark test failures at #9674

I've triggered a re-run of the test to see if it's a flake or not.

@elliette
Copy link
Member

elliette commented Feb 27, 2026

I've triggered a re-run of the test to see if it's a flake or not.

I've disabled these tests for now while I investigate, please sync with master branch and then you should be good to go 🤞

@FMorschel
Copy link
Contributor Author

FMorschel commented Feb 27, 2026

Rebased, thanks a lot!

@FMorschel
Copy link
Contributor Author

FMorschel commented Feb 27, 2026

Can someone please approve the workflow here so this lands? Thanks! I'm down to this last PR before flutter/tests (flutter/flutter and flutter/packages have landed), and I'll be able to make this warning happen!

@FMorschel
Copy link
Contributor Author

FMorschel commented Feb 27, 2026

All checks passed! Thanks a lot everyone!

@kenzieschmoll kenzieschmoll merged commit 946327f into flutter:master Feb 27, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees

No one assigned

Labels

release-notes-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FMorschel @kenzieschmoll @elliette @bkonyi