Just in case the test device has some other UIAccessibility features on can you instead just check that the kOnOffSwitchLabels bit is off?

Same, just check that the kOnOffSwitchLabels bit is on?

I know you added this for testability, but it seems like overkill to add a new header and implementation file for a single wrapper around a function. FlutterPlatformViews_Internal might be a better spot.

I tried adding it to FlutterPlatformViews_Internal, but in the end, failed to do so. I struggled with some ARC-related errors coming in from the underlying imports having an effect on existing test cases.

Instead of going for FlutterPlatformViews, I was able to add it to the FlutterViewController_Internal instead. Hope that will also work for you. Please let me know!

FlutterViewController_Internal.mm doesn't make sense, the implementation is already "internal", the _Internal.h suffix is used to indicate it's not a "public" header and is not exported in the module.

What ARC errors were you seeing?

I can commit the changes if you like if that gives a clearer view. A grasp of the console log, there is more but similair. Do you know how to resolve these issues?

../../flutter/fml/platform/darwin/scoped_nsobject.h:153:28: error: 'NSAutoreleasePool' is unavailable: not available in automatic reference counting mode
  explicit scoped_nsobject(NSAutoreleasePool* object = nil);
                           ^
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.0.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSAutoreleasePool.h:10:12: note: 'NSAutoreleasePool' has been explicitly marked unavailable here
@interface NSAutoreleasePool : NSObject {
           ^
In file included from ../../flutter/shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm:16:
In file included from ../../flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h:10:
../../flutter/fml/platform/darwin/scoped_nsobject.h:51:35: error: 'release' is unavailable: not available in automatic reference counting mode
  ~scoped_nsprotocol() { [object_ release]; }
                                  ^
../../flutter/fml/platform/darwin/scoped_nsobject.h:133:12: note: in instantiation of member function 'fml::scoped_nsprotocol<id>::~scoped_nsprotocol' requested here
  explicit scoped_nsobject(id object = nil) : scoped_nsprotocol<id>(object) {}
           ^
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.0.sdk/usr/include/objc/NSObject.h:37:1: note: 'release' has been explicitly marked unavailable here
- (oneway void)release OBJC_ARC_UNAVAILABLE;

I pasted AccessibilityValueProvider at the bottom of FlutterViewController.m and it compiled fine. You can push up your change if you want me to take a look though.

Ah that's also an option ofcourse, I didn't consider that one yet. Thanks! Will take a look.

Let's try just adding it (as a class property) as the first declaration of FlutterViewController , then testing a partial mock in the test. Kind of a smell to mock out the object under test, but adding a new class for this just to wrap the test still seems like overkill.

@interface FlutterViewController () <FlutterViewResponder>

@property(class, nonatomic, readonly) BOOL accessibilityIsOnOffSwitchLabelsEnabled;
@property(nonatomic, readonly) BOOL isPresentingViewController;
...

Then move the implementation to right under accessibilityFlags

  if ([self class].accessibilityIsOnOffSwitchLabelsEnabled) {
    flags |= static_cast<int32_t>(flutter::AccessibilityFeatureFlag::kOnOffSwitchLabels);
  }

  return flags;
}

+ (BOOL)accessibilityIsOnOffSwitchLabelsEnabled {
  if (@available(iOS 13, *)) {
    return UIAccessibilityIsOnOffSwitchLabelsEnabled();
  } else {
    return NO;
  }
}

Then (also not the NO and YES BOOLs):

Did you mean to change this?

Yes, if I didn't it wouldn't compile.

I had to import

#import "flutter/lib/ui/window/platform_configuration.h"

to get access to the AccessibilityFeatureFlag enum.

platform_configuration imports the implementation of the PointerDataPacket class. Making the one in the tests obsolete.

#include "flutter/lib/ui/window/pointer_data_packet.h"

or this?