This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] add a CIPD browser roller (Chromium only for now) #31740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If a brave soul would like to tackle this while I'm busy with other things in the next couple of days, here's a quick TODO cheatsheet for this PR:
|
|
I did a bunch of changes to add the chromedriver. I still haven't tested the actual upload to CIPD. I might add a tag that is version:96TEST or similar. I just want to be sure Godofredo is around so I don't break things in infra (that might grab by most recently updated package or similar). Current usage: |
|
(force-pushed after rebase with main) |
yjbanov
commented
Mar 2, 2022
yjbanov
commented
Mar 2, 2022
|
I just rolled version:96 + build Id ref, I'll try to restart checks and see what happens: $ dart ./dev/browser_roller.dart --verbose |
|
The linux drone has been able to successfully download Chromium from its ref. Logs. |
|
However: I need to check the previously working version and check what's the internal structure of the ZIP. It must be different than the one that we're downloading now :/ |
|
I just rolled version:96.1 with the latest changes to the packaging of the script (2 copies of the browser+driver in different locations). $ dart ./dev/browser_roller.dart --verbose |
|
Linux tests seem to be passing now, yay! |
|
"Linux Web Framework tests" target is still using a 2 year old version of Chrome |
|
Gold has detected about 13 new digest(s) on patchset 8. |
|
Windows build failed. Looks like some windows canvaskit tests are timing out (on setUpAll???):
Logs: |
|
Looks like some tests may be hanging in |
|
Slightly different set of failures in a rerun:
|
|
Gold has detected about 13 new digest(s) on patchset 9. |
|
Gold has detected about 13 new digest(s) on patchset 10. |
* Refactored code of the script a little bit to reuse some common chunks. * Ensure the CIPD output is compliant with what is expected (currently). We could undo this, but then the CI script needs to change. * Update the browser lock to v96 TODO: Update docs with the new way to update the CIPD bundle TODO: Enable the cipd create command (line 233)
Some recipes require the Chrome executable to be in the root of the CIPD bundle, others inside a `chrome-mac` directory. This change copies the browser so it's available in two locations: * The root of the bundle * The chrome-PLATFORM subdirectory Once recipes are made to agree with each other, the unnecessary copy may be removed. This change also prevents the user to upload a CIPD package with a duplicate version:XX tag. CIPD cannot locate a package if more than one instance has the same version:XX tag.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
…day. Do not duplicate build sizes. That will need to be fixed at the recipe level (being backwards-forwards compatible to the CIPD bundles)
|
Gold has detected about 13 new digest(s) on patchset 13. |
|
@christopherfujino may we get a text exemption for this change? This is a script in |
|
test-exempt: this is a utility script only to be used as part of repo maintenance. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a roller for browser CIPD packages. This initial version only implements a roller for Chromium. We should also add Firefox in the future.