This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add DlImageFilter objects #32140
Merged
Add DlImageFilter objects #32140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new (pod) DlMatrixImageFilter(matrix_filter); | ||
| break; | ||
| } | ||
| case DlImageFilterType::kComposeFilter: |
Member
There was a problem hiding this comment.
There ought to be a break here right?
Contributor
Author
There was a problem hiding this comment.
The fall-through is intentional. Both compose and colorfilter need to be instantiated as the "SharedImageFilter" op because they both contain shared_ptr's in their bodies. I have an issue filed to address that as mentioned in the description above: flutter/flutter#100434
chinmaygarde
approved these changes
Mar 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#100433
The DlComposeImageFilter and DlColorFilterImageFilter can be made to be inlined in the DL records, but that effort can be delayed for higher priority work since these filter types are rarely used. See (flutter/flutter#100434).