Javadoc for background platform chnanels #34774
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| * <p>The handler is called on the platform thread (Android main thread) by default, or | ||
| * otherwise on the thread specified by the task queue provided to the associated {@link | ||
| * MethodChannel} when it was created. See also <a | ||
| * href="https://github.com/flutter/engine/wiki/Threading-in-the-Flutter-Engine">Threading in |
There was a problem hiding this comment.
This link is dead. The updated link is https://github.com/flutter/flutter/wiki/The-Engine-architecture#threading.
There was a problem hiding this comment.
Thanks, this has been corrected
|
The link has been corrected, @gaaclarke can you take a look again? |
| * <p>The handler is called on the platform thread (Android main thread). For more details see | ||
| * <a href="https://github.com/flutter/engine/wiki/Threading-in-the-Flutter-Engine">Threading in | ||
| * <p>The handler is called on the platform thread (Android main thread) by default, or | ||
| * otherwise on the thread specified by the task queue provided to the associated {@link |
There was a problem hiding this comment.
It would be helpful if you linked to TaskQueue instead of saying "task queue".
Update the javadoc for method channels after the background task queue was added.
Related issues:
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.