Delete splash screen guidance with old APIs #35014
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| * | ||
| * <p>{@code <meta-data android:name="io.flutter.embedding.android.SplashScreenDrawable" | ||
| * android:resource="@drawable/launch_background" /> } | ||
| * initialization, DO NOT subclass {@code FlutterActivity} and override {@link |
There was a problem hiding this comment.
As per style guide, we can just use lowecase do not here.
| * <p>{@code <meta-data android:name="io.flutter.embedding.android.SplashScreenDrawable" | ||
| * android:resource="@drawable/launch_background" /> } | ||
| * initialization, DO NOT subclass {@code FlutterActivity} and override {@link | ||
| * #provideSplashScreen()}. Instead, use the instructions above to specify a launch screen that |
There was a problem hiding this comment.
Is there a way to link to it?
There was a problem hiding this comment.
If not, please specify where above as there are multiple sections and this can be confusing.
There was a problem hiding this comment.
I rewrote the comment entirely to catch something I missed and to avoid this strange referencing.
| * first {@code Activity} displayed upon loading the app. | ||
| * | ||
| * <p>Prior to Flutter 2.5, {@code FlutterActivity} supported the display of a Flutter-specific | ||
| * "splash screen" that would be displayed after the launch screen passes; this has since been |
There was a problem hiding this comment.
Nit: Semicolon -> period. Semicolons tend to confuse non-native english speakers.
Modifies guidance as to how to add a custom splash screen to your app.
Part of flutter/flutter#105173.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.