This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add rounded rect SDF blur #35084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Aug 2, 2022
| @@ -93,6 +93,11 @@ def main(): | |||
| command += [ | |||
| '--std=macos-metal1.2', | |||
| ] | |||
| elif args.platform == 'ios': | |||
| command += [ | |||
| '--std=ios-metal1.2', | |||
There was a problem hiding this comment.
It looks like these will get duplicated when args.optimize is true.
There was a problem hiding this comment.
Whoops, this wasn't an intentional change, removed. It's a diff I lug around in my git stage to stop the xcode GPU profiler from crashing in debug unopt.
chinmaygarde
approved these changes
Aug 2, 2022
| frag_info.corner_radius = | ||
| std::min(corner_radius_, std::min(positive_rect.size.width / 2.0f, | ||
| positive_rect.size.height / 2.0f)); | ||
| ; |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Aug 5, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an SDF blur that can be used for rects, rounded rects, and circles.
Uses #35083.
Right now there are visible corner artifacts when the blur radius is larger than the corner radius due to gradient discontinuities. I'm experimenting with a couple of promising solutions for this (one that samples the field a few times and one that interpolates with another field), but I figured I'd land this initial implementation since everything else is in place.
Will probably move some of the utilities into the shader lib depending on what the final solution ends up needing.
Screen.Recording.2022-08-02.at.3.55.23.AM.mov