This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fixes Android text field to use hint text for accessibility #36846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryQian
reviewed
Oct 25, 2022
|
|
||
| private CharSequence getValueLabelHint() { | ||
| CharSequence[] array = new CharSequence[] {getValue(), getLabel(), getHint()}; | ||
| ; |
GaryQian
reviewed
Oct 25, 2022
|
|
||
| private CharSequence getTextFieldHint() { | ||
| CharSequence[] array = new CharSequence[] {getLabel(), getHint()}; | ||
| ; |
752e7b9 to
a381f70
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2022
GaryQian
added a commit
that referenced
this pull request
Oct 27, 2022
chunhtai
added a commit
to chunhtai/engine
that referenced
this pull request
Oct 27, 2022
…lutter#36846)" This reverts commit 8bb0441.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#113457
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.