This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add strong qualifier to dartEntrypointArguments. #36929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is causing issue when -Wobjc-property-no-attribute is turned on. Since LLVM 3.1, `strong` has been the default value so this change is effectively a no-op, but improves readability.
zanderso
approved these changes
Oct 21, 2022
|
LGTM! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2022
chingjun
added a commit
to chingjun/engine
that referenced
this pull request
Nov 18, 2022
This is causing issue when -Wobjc-property-no-attribute is turned on. Since LLVM 3.1, strong has been the default value so this change is effectively a no-op, but improves readability. Similar to flutter#36929
8 tasks
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing issue when
-Wobjc-property-no-attributeis turned on.Since LLVM 3.1,
stronghas been the default value so this change is effectively a no-op, but improves readability.Context: b/254864882
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.