This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix stuttering in playgrounds due to precision issue #37035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Oct 26, 2022
| @@ -22,6 +24,8 @@ void PlaygroundTest::SetUp() { | |||
| } | |||
|
|
|||
| SetupWindow(GetParam()); | |||
|
|
|||
| start_time_ = fml::TimePoint::Now().ToEpochDelta().ToSecondsF(); | |||
There was a problem hiding this comment.
If you retain start_time_ as a TimeDelta (that is skip the .ToSecondsF() here), then GetSecondsElapsed() becomes (fml::TimePoint::Now().ToEpochDelta() - start_time_).ToSecondsF(), and you only have one int -> double conversion instead of two.
e2acd54 to
23808c5
Compare
zanderso
approved these changes
Oct 26, 2022
|
auto label is removed for flutter/engine, pr: 37035, due to - The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
23808c5 to
c2ae4bf
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the oldest item on my investigation todo! Turns out float precision isn't high enough for casting from the epoch seconds double.
Before:
Screen.Recording.2022-10-26.at.3.45.17.AM.mov
After:
Screen.Recording.2022-10-26.at.3.44.26.AM.mov