Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Add more cursor plugin tests #38112

Merged
merged 3 commits into from
Dec 8, 2022
Merged

[Windows] Add more cursor plugin tests #38112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03bb032
[Windows] Add more cursor plugin tests
loic-sharma Dec 6, 2022
ab8ace0
Tweak
loic-sharma Dec 6, 2022
58ba154
Add dependency
loic-sharma Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shell/platform/windows/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ executable("flutter_windows_unittests") {
":flutter_windows_headers",
":flutter_windows_source",
"//flutter/shell/platform/common:common_cpp",
"//flutter/shell/platform/common/client_wrapper:client_wrapper",
"//flutter/shell/platform/embedder:embedder_as_internal_library",
"//flutter/shell/platform/embedder:embedder_test_utils",
"//flutter/testing",
Expand Down
228 changes: 218 additions & 10 deletions shell/platform/windows/cursor_handler_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,229 @@
#include <memory>
#include <vector>

#include "flutter/shell/platform/common/client_wrapper/include/flutter/method_result_functions.h"
#include "flutter/shell/platform/common/client_wrapper/include/flutter/standard_message_codec.h"
#include "flutter/shell/platform/common/client_wrapper/include/flutter/standard_method_codec.h"
#include "flutter/shell/platform/windows/flutter_windows_view.h"
#include "flutter/shell/platform/windows/testing/mock_window_binding_handler.h"
#include "flutter/shell/platform/windows/testing/test_binary_messenger.h"
#include "gmock/gmock.h"
#include "gtest/gtest.h"

namespace flutter {
namespace testing {
TEST(CursorHandlerTest, CreateDummyCursor) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was replaced by the SetCustomCursor test

// Create a 4x4 rawBGRA dummy cursor buffer.
std::vector<uint8_t> buffer;
for (int i = 0; i < 4 * 4 * 4; i++) {
buffer.push_back(0);
}
// Create the cursor from buffer provided above.
auto cursor = GetCursorFromBuffer(buffer, 0.0, 0.0, 4, 4);
// Expect cursor is not null.
EXPECT_NE(cursor, nullptr);

namespace {
using ::testing::_;
using ::testing::NotNull;
using ::testing::Return;

static constexpr char kChannelName[] = "flutter/mousecursor";

static constexpr char kActivateSystemCursorMethod[] = "activateSystemCursor";
static constexpr char kCreateCustomCursorMethod[] =
"createCustomCursor/windows";
static constexpr char kSetCustomCursorMethod[] = "setCustomCursor/windows";
static constexpr char kDeleteCustomCursorMethod[] =
"deleteCustomCursor/windows";

void SimulateCursorMessage(TestBinaryMessenger* messenger,
const std::string& method_name,
std::unique_ptr<EncodableValue> arguments,
MethodResult<EncodableValue>* result_handler) {
MethodCall<> call(method_name, std::move(arguments));

auto message = StandardMethodCodec::GetInstance().EncodeMethodCall(call);

EXPECT_TRUE(messenger->SimulateEngineMessage(
kChannelName, message->data(), message->size(),
[&result_handler](const uint8_t* reply, size_t reply_size) {
StandardMethodCodec::GetInstance().DecodeAndProcessResponseEnvelope(
reply, reply_size, result_handler);
}));
}

} // namespace

TEST(CursorHandlerTest, ActivateSystemCursor) {
TestBinaryMessenger messenger;
MockWindowBindingHandler window;
CursorHandler cursor_handler(&messenger, &window);

EXPECT_CALL(window, UpdateFlutterCursor("click")).Times(1);

bool success = false;
MethodResultFunctions<> result_handler(
[&success](const EncodableValue* result) {
success = true;
EXPECT_EQ(result, nullptr);
},
nullptr, nullptr);

SimulateCursorMessage(&messenger, kActivateSystemCursorMethod,
std::make_unique<EncodableValue>(EncodableMap{
{EncodableValue("device"), EncodableValue(0)},
{EncodableValue("kind"), EncodableValue("click")},
}),
&result_handler);

EXPECT_TRUE(success);
}

TEST(CursorHandlerTest, CreateCustomCursor) {
TestBinaryMessenger messenger;
MockWindowBindingHandler window;
CursorHandler cursor_handler(&messenger, &window);

// Create a 4x4 raw BGRA test cursor buffer.
std::vector<uint8_t> buffer(4 * 4 * 4, 0);

bool success = false;
MethodResultFunctions<> result_handler(
[&success](const EncodableValue* result) {
success = true;
EXPECT_EQ(std::get<std::string>(*result), "hello");
},
nullptr, nullptr);

SimulateCursorMessage(&messenger, kCreateCustomCursorMethod,
std::make_unique<EncodableValue>(EncodableMap{
{EncodableValue("name"), EncodableValue("hello")},
{EncodableValue("buffer"), EncodableValue(buffer)},
{EncodableValue("width"), EncodableValue(4)},
{EncodableValue("height"), EncodableValue(4)},
{EncodableValue("hotX"), EncodableValue(0.0)},
{EncodableValue("hotY"), EncodableValue(0.0)},
}),
&result_handler);

EXPECT_TRUE(success);
}

TEST(CursorHandlerTest, SetCustomCursor) {
TestBinaryMessenger messenger;
MockWindowBindingHandler window;
CursorHandler cursor_handler(&messenger, &window);

// Create a 4x4 raw BGRA test cursor buffer.
std::vector<uint8_t> buffer(4 * 4 * 4, 0);

bool success = false;
MethodResultFunctions<> create_result_handler(nullptr, nullptr, nullptr);
MethodResultFunctions<> set_result_handler(
[&success](const EncodableValue* result) {
success = true;
EXPECT_EQ(result, nullptr);
},
nullptr, nullptr);

EXPECT_CALL(window, SetFlutterCursor(/*cursor=*/NotNull())).Times(1);

SimulateCursorMessage(&messenger, kCreateCustomCursorMethod,
std::make_unique<EncodableValue>(EncodableMap{
{EncodableValue("name"), EncodableValue("hello")},
{EncodableValue("buffer"), EncodableValue(buffer)},
{EncodableValue("width"), EncodableValue(4)},
{EncodableValue("height"), EncodableValue(4)},
{EncodableValue("hotX"), EncodableValue(0.0)},
{EncodableValue("hotY"), EncodableValue(0.0)},
}),
&create_result_handler);

SimulateCursorMessage(&messenger, kSetCustomCursorMethod,
std::make_unique<EncodableValue>(EncodableMap{
{EncodableValue("name"), EncodableValue("hello")},
}),
&set_result_handler);

EXPECT_TRUE(success);
}

TEST(CursorHandlerTest, SetNonexistentCustomCursor) {
TestBinaryMessenger messenger;
MockWindowBindingHandler window;
CursorHandler cursor_handler(&messenger, &window);

bool error = false;
MethodResultFunctions<> result_handler(
nullptr,
[&error](const std::string& error_code, const std::string& error_message,
const EncodableValue* value) {
error = true;
EXPECT_EQ(
error_message,
"The custom cursor identified by the argument key cannot be found");
},
nullptr);

EXPECT_CALL(window, SetFlutterCursor).Times(0);

SimulateCursorMessage(&messenger, kSetCustomCursorMethod,
std::make_unique<EncodableValue>(EncodableMap{
{EncodableValue("name"), EncodableValue("hello")},
}),
&result_handler);

EXPECT_TRUE(error);
}

TEST(CursorHandlerTest, DeleteCustomCursor) {
TestBinaryMessenger messenger;
MockWindowBindingHandler window;
CursorHandler cursor_handler(&messenger, &window);

// Create a 4x4 raw BGRA test cursor buffer.
std::vector<uint8_t> buffer(4 * 4 * 4, 0);

bool success = false;
MethodResultFunctions<> create_result_handler(nullptr, nullptr, nullptr);
MethodResultFunctions<> delete_result_handler(
[&success](const EncodableValue* result) {
success = true;
EXPECT_EQ(result, nullptr);
},
nullptr, nullptr);

SimulateCursorMessage(&messenger, kCreateCustomCursorMethod,
std::make_unique<EncodableValue>(EncodableMap{
{EncodableValue("name"), EncodableValue("hello")},
{EncodableValue("buffer"), EncodableValue(buffer)},
{EncodableValue("width"), EncodableValue(4)},
{EncodableValue("height"), EncodableValue(4)},
{EncodableValue("hotX"), EncodableValue(0.0)},
{EncodableValue("hotY"), EncodableValue(0.0)},
}),
&create_result_handler);

SimulateCursorMessage(&messenger, kDeleteCustomCursorMethod,
std::make_unique<EncodableValue>(EncodableMap{
{EncodableValue("name"), EncodableValue("hello")},
}),
&delete_result_handler);

EXPECT_TRUE(success);
}

TEST(CursorHandlerTest, DeleteNonexistentCustomCursor) {
TestBinaryMessenger messenger;
MockWindowBindingHandler handler;
CursorHandler cursor_handler(&messenger, &handler);

bool success = false;
MethodResultFunctions<> result_handler(
[&success](const EncodableValue* result) {
success = true;
EXPECT_EQ(result, nullptr);
},
nullptr, nullptr);

SimulateCursorMessage(&messenger, kDeleteCustomCursorMethod,
std::make_unique<EncodableValue>(EncodableMap{
{EncodableValue("name"), EncodableValue("fake")},
}),
&result_handler);

EXPECT_TRUE(success);
}

} // namespace testing
Expand Down