Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Deprecate SingletonFlutterWindow and global window singleton #39302

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Deprecate SingletonFlutterWindow and global window singleton #39302

merged 6 commits into from
Mar 21, 2023

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Jan 31, 2023 •
edited
Loading

Part of flutter/flutter#116929.

Migration Guide: flutter/website#8283

To be submitted after flutter/flutter#120998.

@goderbauer
Copy link
Member Author

@gspencergoog @Piinks @dkwingsmt @loic-sharma This is not quite ready for submission yet, but looking for some early feedback here on the wording.

@goderbauer goderbauer mentioned this pull request Jan 31, 2023
Closed
33 tasks
loic-sharma
loic-sharma reviewed Jan 31, 2023
View reviewed changes
loic-sharma
loic-sharma reviewed Jan 31, 2023
View reviewed changes
loic-sharma
loic-sharma reviewed Jan 31, 2023
View reviewed changes
loic-sharma
loic-sharma reviewed Jan 31, 2023
View reviewed changes
Piinks
Piinks reviewed Feb 1, 2023
View reviewed changes
Piinks
Piinks reviewed Feb 1, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording looks great modulo the migration info.

@Piinks Piinks mentioned this pull request Feb 1, 2023
Merged
@Piinks
Copy link
Contributor

Piinks commented Feb 1, 2023

Shared comment with https://github.com/flutter/flutter/pull/119647/files#r1092625077 re: mention of upcoming support for multi window

dkwingsmt
dkwingsmt reviewed Feb 2, 2023
View reviewed changes
@goderbauer goderbauer mentioned this pull request Mar 10, 2023
Merged
@goderbauer goderbauer marked this pull request as ready for review March 15, 2023 20:47
@goderbauer goderbauer requested a review from loic-sharma March 15, 2023 20:47
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Mar 15, 2023

test-exempt: only affects comments (and metadata)

pdblasi-google
pdblasi-google approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Piinks
Piinks approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

gspencergoog
gspencergoog approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never been happier to approve a deprecation!

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit e916277 into flutter:main Mar 21, 2023
@goderbauer goderbauer deleted the deprecateWindow2 branch March 21, 2023 23:18
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 21, 2023
@engine-flutter-autoroll
e916277e4 Deprecate SingletonFlutterWindow and global window singleton (
8362c6c 
flutter/engine#39302)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 21, 2023
@engine-flutter-autoroll
e916277e4 Deprecate SingletonFlutterWindow and global window singleton (
a886c02 
flutter/engine#39302)
bdero added a commit that referenced this pull request Mar 22, 2023
@bdero
Revert "Deprecate SingletonFlutterWindow and global window singleton (#…
3a6af38 
…39302)"

This reverts commit e916277.
@bdero bdero mentioned this pull request Mar 22, 2023
Merged
@goderbauer goderbauer mentioned this pull request Mar 22, 2023
Merged
11 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
e916277e4 Deprecate SingletonFlutterWindow and global window singleton (
604e499 
flutter/engine#39302)
auto-submit bot pushed a commit that referenced this pull request Mar 22, 2023
@bdero
Revert "Deprecate SingletonFlutterWindow and global window singleton (#…
62f2844 
…39302)" (#40507)

Revert "Deprecate SingletonFlutterWindow and global window singleton"
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
e916277e4 Deprecate SingletonFlutterWindow and global window singleton (
9c03bab 
flutter/engine#39302)
goderbauer added a commit to goderbauer/engine that referenced this pull request Mar 22, 2023
@goderbauer
Reland "Deprecate SingletonFlutterWindow and global window singleton (f…
3feca1a 
…lutter#39302)"

This reverts commit 62f2844.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
e916277e4 Deprecate SingletonFlutterWindow and global window singleton (
7076895 
flutter/engine#39302)
auto-submit bot pushed a commit that referenced this pull request Mar 22, 2023
@goderbauer
Reland "Deprecate SingletonFlutterWindow and global window singleton (#…
2d6803c 
…39302)" (#40511)

Reland "Deprecate SingletonFlutterWindow and global window singleton (#39302)"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dkwingsmt dkwingsmt dkwingsmt left review comments

@gspencergoog gspencergoog gspencergoog approved these changes

@Piinks Piinks Piinks approved these changes

@pdblasi-google pdblasi-google pdblasi-google approved these changes

@loic-sharma loic-sharma Awaiting requested review from loic-sharma

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests
Projects
Multi Window
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@goderbauer @Piinks @Hixie @loic-sharma @dkwingsmt @gspencergoog @pdblasi-google