Remove single-window assumption from scenario_app #40156
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -540,7 +518,7 @@ class MultiPlatformViewBackgroundForegroundScenario extends Scenario | |||
| if (_lastLifecycleState == 'AppLifecycleState.inactive' && | |||
| message == 'AppLifecycleState.resumed') { | |||
| _nextFrame = _secondFrame; | |||
| window.scheduleFrame(); | |||
| view.platformDispatcher.scheduleFrame(); | |||
There was a problem hiding this comment.
Hm, one day we may want to schedule a frame for a single view instead of all views. Food for thought, not at all relevant to this change :)
There was a problem hiding this comment.
Yeah, this is something that comes up every now and then. Since we want a unified widget tree, frame scheduling is always gonna be global. There is some discussion on that in https://flutter.dev/go/multiple-views in the Background section.
Part of flutter/flutter#116929.