Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add builders for second level cache of builders. #42271

Merged
merged 2 commits into from
May 24, 2023
Merged

Add builders for second level cache of builders. #42271

merged 2 commits into from
May 24, 2023

Conversation

godofredoc
Copy link
Contributor

These builders will generate CAS caches to optimize engine checkouts.

Bug: flutter/flutter#127433

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

These builders will generate cas caches to optimize engine checkouts.

Bug: flutter/flutter#127433
Copy link
Contributor

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2023
@auto-submit auto-submit bot merged commit 1f964fa into flutter:main May 24, 2023
@godofredoc godofredoc deleted the add_cache_builder branch May 24, 2023 02:00
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 24, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 24, 2023
…127458)

flutter/engine@aba9dc4...eebcf36

2023-05-24 [email protected] [Impeller] Limit rrect blur kernel to 1000x1000 (flutter/engine#42269)
2023-05-24 [email protected] Add builders for second level cache of builders. (flutter/engine#42271)
2023-05-24 [email protected] [Impeller] remove framebuffer blending from atlas, fix transform scale (flutter/engine#42254)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…lutter#127458)

flutter/engine@aba9dc4...eebcf36

2023-05-24 [email protected] [Impeller] Limit rrect blur kernel to 1000x1000 (flutter/engine#42269)
2023-05-24 [email protected] Add builders for second level cache of builders. (flutter/engine#42271)
2023-05-24 [email protected] [Impeller] remove framebuffer blending from atlas, fix transform scale (flutter/engine#42254)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants