Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove unused autosubmit configuration file #43483

Merged

Conversation

ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Jul 7, 2023

Remove autosubmit config files that are no longer being used. This was from a previous design and not longer used.

List which issues are fixed by this PR. You must list at least one issue.
Part of flutter/flutter#130182

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2023
@auto-submit auto-submit bot merged commit 4ca6191 into flutter:main Jul 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 8, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 8, 2023
…130191)

flutter/engine@13d9d84...4ca6191

2023-07-08 [email protected] Remove unused autosubmit configuration file (flutter/engine#43483)
2023-07-07 [email protected] Roll Skia from 2885452c3fb1 to 6d733caa0d3f (1 revision) (flutter/engine#43482)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick pushed a commit to kjlubick/engine that referenced this pull request Jul 14, 2023
Remove autosubmit config files that are no longer being used. This was from a previous design and not longer used.

List which issues are fixed by this PR. You must list at least one issue.
Part of flutter/flutter#130182

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@ricardoamador ricardoamador deleted the config_autosub_cleanup_130182 branch February 5, 2024 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants