Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Improve Stencil Playground test #43641

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

johnmccutchan
Copy link
Contributor

  • Add UI to select front and back face comparision functions.
  • Fix back face.

Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ one include nit.

- Add UI to select front and back face comparision functions.
- Fix back face.
@johnmccutchan johnmccutchan merged commit 5845102 into flutter:main Jul 13, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 13, 2023
…130512)

flutter/engine@081fbab...c31cfc5

2023-07-13 [email protected] [Impeller] Switch back to using explicit flush for device buffers. (flutter/engine#43644)
2023-07-13 [email protected] Add logs to debug VM Service Publication (flutter/engine#43616)
2023-07-13 [email protected] Revert "Add a flag to `ParagraphBuilder` for rounding hack migration" (flutter/engine#43642)
2023-07-13 [email protected] [web] TextField a11y focus should call didGain/didLose a11y focus action (flutter/engine#43279)
2023-07-13 [email protected] Improve Stencil Playground test (flutter/engine#43641)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick pushed a commit to kjlubick/engine that referenced this pull request Jul 14, 2023
- Add UI to select front and back face comparision functions.
- Fix back face.
harryterkelsen pushed a commit to harryterkelsen/engine that referenced this pull request Jul 20, 2023
- Add UI to select front and back face comparision functions.
- Fix back face.
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
…lutter#130512)

flutter/engine@081fbab...c31cfc5

2023-07-13 [email protected] [Impeller] Switch back to using explicit flush for device buffers. (flutter/engine#43644)
2023-07-13 [email protected] Add logs to debug VM Service Publication (flutter/engine#43616)
2023-07-13 [email protected] Revert "Add a flag to `ParagraphBuilder` for rounding hack migration" (flutter/engine#43642)
2023-07-13 [email protected] [web] TextField a11y focus should call didGain/didLose a11y focus action (flutter/engine#43279)
2023-07-13 [email protected] Improve Stencil Playground test (flutter/engine#43641)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants