This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyebrowsoffire
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 14, 2023
…132522) flutter/engine@56a0e27...785b249 2023-08-14 [email protected] Update CompositionAwareMixin to correctly compute composingBase in Web engine (flutter/engine#44139) 2023-08-14 [email protected] Add application:openURLs: forwarding on macOS (flutter/engine#44689) 2023-08-14 [email protected] Roll Skia from a4377099b25a to 69ea58157190 (1 revision) (flutter/engine#44692) 2023-08-14 [email protected] Update embedder_semantics_update.h imports to include flutter namespace (flutter/engine#44670) 2023-08-14 [email protected] Roll Dart SDK from 3295a353980a to d445f5a18876 (1 revision) (flutter/engine#44691) 2023-08-14 [email protected] Revert "Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib" (flutter/engine#44690) 2023-08-14 [email protected] Roll Skia from 1cf6f71c8120 to a4377099b25a (1 revision) (flutter/engine#44688) 2023-08-14 [email protected] Roll Fuchsia Mac SDK from JKTVoxVrHjZjBaxG4... to uIGMbDkXoIcpqWjgR... (flutter/engine#44687) 2023-08-14 [email protected] [Impeller] Conditionally set command debug info. (flutter/engine#44274) 2023-08-14 [email protected] Migrate more GL calls of GrBackend* (flutter/engine#44682) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from JKTVoxVrHjZj to uIGMbDkXoIcp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Follow-up to flutter#44334 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
HinTak
added a commit
to HinTak/skia-m1xx-python
that referenced
this pull request
Oct 6, 2023
commit 2cf149beae3fdb70f689ab3b64b138f1fdd5bd0c Author: Kevin Lubick <[email protected]> Date: Mon Aug 14 10:36:08 2023 -0400 Remove bridge code for legacy GL GrBackendSurface code While doing this, I ran into a small #include issue with GrGLGpu, so I enforced IWYU on it. Client CLs: - https://crrev.com/c/4739911 - http://cl/553620143 - http://cl/553628593 - http://cl/553637942 - http://cl/553705311 - http://cl/553821763 - http://cl/553837992 - http://ag/24343000 - http://ag/24343454 - http://ag/24420576 - http://ag/24445187 - flutter/engine#44334 - flutter/engine#44682 Change-Id: If07cbe3a60593810911c147b8a81e30459623f28 Bug: b/293490566 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/741437 Reviewed-by: Greg Daniel <[email protected]> Reviewed-by: Brian Osman <[email protected]> Commit-Queue: Kevin Lubick <[email protected]>
HinTak
added a commit
to HinTak/skia-m1xx-python
that referenced
this pull request
Oct 6, 2023
commit 2cf149beae3fdb70f689ab3b64b138f1fdd5bd0c Author: Kevin Lubick <[email protected]> Date: Mon Aug 14 10:36:08 2023 -0400 Remove bridge code for legacy GL GrBackendSurface code While doing this, I ran into a small #include issue with GrGLGpu, so I enforced IWYU on it. Client CLs: - https://crrev.com/c/4739911 - http://cl/553620143 - http://cl/553628593 - http://cl/553637942 - http://cl/553705311 - http://cl/553821763 - http://cl/553837992 - http://ag/24343000 - http://ag/24343454 - http://ag/24420576 - http://ag/24445187 - flutter/engine#44334 - flutter/engine#44682 Change-Id: If07cbe3a60593810911c147b8a81e30459623f28 Bug: b/293490566 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/741437 Reviewed-by: Greg Daniel <[email protected]> Reviewed-by: Brian Osman <[email protected]> Commit-Queue: Kevin Lubick <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #44334
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.