This repository was archived by the owner on Feb 25, 2025. It is now read-only.
wip: [macOS] Wrap FlutterTextInputPlugin tests in autorelase pool #47516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraps all FlutterTextInputPlugin tests in an autorelease pool to ensure
resources are cleaned up between tests.
Prior to this change, running these tests via:
../out/host_debug_unopt_arm64/flutter_desktop_darwin_unittests \
--gtest_repeat=1000 \
--gtest_filter='FlutterTextInputPluginTest.TestFirstRectForCharacterRange'
Resuling in a test failure:
```
[ RUN ] FlutterTextInputPluginTest.TestFirstRectForCharacterRange
2023-10-31 10:30:48.497112-0700 flutter_desktop_darwin_unittests[5304:4897209] Could not create Metal command queue.
2023-10-31 10:30:48.497761-0700 flutter_desktop_darwin_unittests[5304:4897209] Unable to create FlutterView; no MTLDevice or MTLCommandQueue available.
2023-10-31 10:30:48.520949-0700 flutter_desktop_darwin_unittests[5304:4897209] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Did not record an invocation in OCMStub/OCMExpect/OCMReject.
Possible causes are:
- The receiver is not a mock object.
- The selector conflicts with a selector implemented by OCMStubRecorder/OCMExpectationRecorder.'
*** First throw call stack:
(
0 CoreFoundation 0x000000018b1f6800 __exceptionPreprocess + 176
1 libobjc.A.dylib 0x000000018acedeb4 objc_exception_throw + 60
2 CoreFoundation 0x000000018b1f66f0 +[NSException exceptionWithName:reason:userInfo:] + 0
3 flutter_desktop_darwin_unittests 0x00000001039318a0 +[OCMMacroState endStubMacro] + 272
4 flutter_desktop_darwin_unittests 0x0000000100138858 -[FlutterInputPluginTestObjc testFirstRectForCharacterRange] + 1316
5 flutter_desktop_darwin_unittests 0x0000000100152e04 _ZN7flutter7testing62FlutterTextInputPluginTest_TestFirstRectForCharacterRange_Test8TestBodyEv + 60
6 flutter_d
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Did not record an invocation in OCMStub/OCMExpect/OCMReject.
Possible causes are:
- The receiver is not a mock object.
- The selector conflicts with a selector implemented by OCMStubRecorder/OCMExpectationRecorder.'
*** First throw call stack:
(
0 CoreFoundation 0x000000018b1f6800 __exceptionPreprocess + 176
1 libobjc.A.dylib 0x000000018acedeb4 objc_exception_throw + 60
2 CoreFoundation 0x000000018b1f66f0 +[NSException exceptionWithName:reason:userInfo:] + 0
3 flutter_desktop_darwin_unittests 0x00000001039318a0 +[OCMMacroState endStubMacro] + 272
4 flutter_desktop_darwin_unittests 0x0000000100138858 -[FlutterInputPluginTestObjc testFirstRectForCharacterRange] + 1316
```
Issue: flutter/flutter#104789
Issue: flutter/flutter#127441
Issue: flutter/flutter#124840
|
Marking as WIP. Turns out that cleaning up memory here breaks another test. Will fix then update the patch. |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
|
I'm going to drop this patch for the time being; I will get back to this and it still needs to be done, but there's a bit more complexity to this one than there initially seemed to be. (Specifically we're relying the test being leaky at the moment 😞) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps all FlutterTextInputPlugin tests in an autorelease pool to ensure resources are cleaned up between tests.
Prior to this change, running these tests via:
Resuling in a test failure:
Issue: flutter/flutter#104789
Issue: flutter/flutter#127441
Issue: flutter/flutter#124840
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.