Fix css changes with macOS 13 and Safari #48807
Conversation
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Ooof I was hoping this would be as simple as just making the expectations more flexible, but looks like it also affects the golden files. This might be too far out of my knowledge to fix. |
|
@yjbanov Do you know what I need to do about the goldens? I'm not familiar with how that works |
|
@yjbanov I changed this back to keep only running on macOS 12. I also filed a separate issue for the golden files since I'm unsure how to fix: flutter/flutter#139924 |
…139933) flutter/engine@9b85b76...5587d26 2023-12-11 [email protected] Fix _availability_version_check for iOS 11 and 12 (flutter/engine#48624) 2023-12-11 [email protected] [Impeller] remove trace events that have outlived their usefulness. (flutter/engine#48856) 2023-12-11 [email protected] Fix css changes with macOS 13 and Safari (flutter/engine#48807) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Safari on macOS 13 outputs different styling than before. Adjust tests to accept new changes. Fixes flutter/flutter#136274. Fixes flutter/flutter#136279. Example passing on macOS 12: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_web_engine/16401/overview Example passing on macOS 13: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_web_engine/16396/overview [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Safari on macOS 13 outputs different styling than before. Adjust tests to accept new changes.
Fixes flutter/flutter#136274. Fixes flutter/flutter#136279.
Example passing on macOS 12: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_web_engine/16401/overview
Example passing on macOS 13: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_web_engine/16396/overview
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.