Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Bump Robolectric to 4.11.1 #51310

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Bump Robolectric to 4.11.1 #51310

merged 4 commits into from
Mar 11, 2024

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Mar 9, 2024 •
edited
Loading

Bump Robolectric to the latest stable 4.11.1.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@utzcoz utzcoz changed the title Android testing use min sdk 21 Bump Robolectric to 4.11 Mar 9, 2024
@utzcoz utzcoz changed the title Bump Robolectric to 4.11 Bump Robolectric to 4.11.1 Mar 9, 2024
@utzcoz
Copy link
Contributor Author

utzcoz commented Mar 9, 2024

Hi @dnfield , I saw you have applied changes for minSdk 21, so I created this PR to update Robolectric to 4.11.1 only.

@utzcoz utzcoz marked this pull request as ready for review March 9, 2024 12:13
@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Mar 10, 2024

auto label is removed for flutter/engine/51310, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@utzcoz
Copy link
Contributor Author

utzcoz commented Mar 10, 2024

@dnfield Thanks for your reviewing. Could you help to invite another people to review this PR? It might require at least two people's reviewing. Thanks.

@dnfield dnfield requested review from reidbaker and gmackall March 10, 2024 21:28
gmackall
gmackall approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@utzcoz
Copy link
Contributor Author

utzcoz commented Mar 11, 2024

Thanks. Can you help to add the autosubmit label?

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #51310 at sha 8f9f9ac

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2024
@auto-submit auto-submit bot merged commit 3b0b59b into flutter:main Mar 11, 2024
@utzcoz utzcoz deleted the Android-testing-use-minSdk-21 branch March 11, 2024 07:49
@utzcoz
Copy link
Contributor Author

utzcoz commented Mar 11, 2024

Thanks for reviewing.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2024
@engine-flutter-autoroll
3b0b59bb2 Bump Robolectric to 4.11.1 (flutter/engine#51310)
6193cf5
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 11, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 210f84eb818b to 3b0b59bb224d (1 revision) (#…
3bb2e59 
…144923)

flutter/engine@210f84e...3b0b59b

2024-03-11 [email protected] Bump Robolectric to 4.11.1 (flutter/engine#51310)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reidbaker reidbaker Awaiting requested review from reidbaker

2 more reviewers

@dnfield dnfield dnfield approved these changes

@gmackall gmackall gmackall approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android will affect goldens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utzcoz @dnfield @gmackall