Thanks to visit codestin.com
Credit goes to github.com

Skip to content

☔️ Remove UWP support #102172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
11 tasks done
cbracken opened this issue Apr 19, 2022 · 4 comments
Closed
11 tasks done

☔️ Remove UWP support #102172

cbracken opened this issue Apr 19, 2022 · 4 comments
Assignees
@cbracken
Labels
a: desktop Running on desktop c: tech-debt Technical debt, code quality, testing, etc. P2 Important issues not at the top of the work list platform-windows Building on or for Windows specifically

Comments

@cbracken
Copy link
Member

cbracken commented Apr 19, 2022 •
edited
Loading

With the decision to wind down continued development of the Windows UWP embedder, we'll need to clean up existing work that has landed.

  • Delete any UWP-related documentation from flutter.dev and the wiki.
  • Remove UWP support from any codelabs, samples, etc.
  • Remove UWP app support in the tool (template, logic, etc.)
  • Eliminate UWP plugin support in the tool (template, logic, etc.)
  • Eliminate UWP infra for flutter/plugins (e.g. [flutter_plugin_tool] Add support for building UWP plugins plugins#4047, [ci] Enable the new Windows targets plugins#4325)
  • Disable building, testing, and uploading UWP artifacts on our engine bots
    • Eliminate Windows UWP Engine target from engine .ci.yaml.
    • Wait for the CI target change to roll to the flutter/infra repo.
    • Delete UWP support from engine recipe
  • Eliminate UWP support from the gn wrapper
  • Delete UWP embedder source/build files. Close any TODO-related bugs that appear in that code that don't also appear elsewhere.
@cbracken cbracken added platform-windows Building on or for Windows specifically a: desktop Running on desktop P2 Important issues not at the top of the work list e: uwp c: tech-debt Technical debt, code quality, testing, etc. labels Apr 19, 2022
@fabiancrx fabiancrx mentioned this issue Apr 19, 2022
Closed
@jonahwilliams jonahwilliams mentioned this issue Apr 19, 2022
Merged
@cbracken cbracken self-assigned this Apr 26, 2022
@cbracken
Copy link
Member Author

Plugins removal happened in:

@cbracken
Copy link
Member Author

Recipe removal patch: https://flutter-review.googlesource.com/c/recipes/+/29500

cbracken added a commit to cbracken/flutter_engine that referenced this issue Apr 29, 2022
@cbracken
Remove Windows UWP Engine target
6d7ba31 
Removes the Windows UWP Engine target from CI.

UWP support was removed from the tool in:
https://flutter-review.googlesource.com/c/recipes/+/29500

UWP support will be removed from the recipe in:
https://flutter-review.googlesource.com/c/recipes/+/29500

UWP infra will be removed in a future patch.

Issue: flutter/flutter#102172
@cbracken cbracken mentioned this issue Apr 29, 2022
Merged
8 tasks
cbracken added a commit to flutter/engine that referenced this issue Apr 29, 2022
@cbracken
Remove Windows UWP Engine target (#33012)
7fa276c 
Removes the Windows UWP Engine target from CI.

UWP support was removed from the tool in:
https://flutter-review.googlesource.com/c/recipes/+/29500

UWP support will be removed from the recipe in:
https://flutter-review.googlesource.com/c/recipes/+/29500

UWP infra will be removed in a future patch.

Issue: flutter/flutter#102172
cbracken added a commit to cbracken/flutter_engine that referenced this issue Apr 29, 2022
@cbracken
WinUWP: remove uses of build_windows_uwp
d77d4b7 
The UWP build has been removed, and this variable is no longer used in
the recipe.

Issue: flutter/flutter#102172
@cbracken cbracken mentioned this issue Apr 29, 2022
Merged
8 tasks
cbracken added a commit to cbracken/flutter_engine that referenced this issue Apr 29, 2022
@cbracken
WinUWP: Remove UWP support from gn wrapper
f40e84a 
This removes the --winuwp option from the Flutter gn wrapper script,
eliminating the winuwp configurations.

Tool support was removed in:
flutter/flutter#102174

CI target was removed in:
flutter#33012

Build recipe was removed in:
https://flutter-review.googlesource.com/c/recipes/+/29500

Issue: flutter/flutter#102172
cbracken added a commit to cbracken/flutter_engine that referenced this issue Apr 29, 2022
@cbracken
WinUWP: Remove UWP support from gn wrapper
81c8a9f 
This removes the --winuwp option from the Flutter gn wrapper script,
eliminating the winuwp configurations. UWP-specific code and build
targets will be removed in followup patches.

Tool support was removed in:
flutter/flutter#102174

CI target was removed in:
flutter#33012

Build recipe was removed in:
https://flutter-review.googlesource.com/c/recipes/+/29500

Issue: flutter/flutter#102172
@cbracken cbracken mentioned this issue Apr 29, 2022
Merged
8 tasks
cbracken added a commit to cbracken/flutter_engine that referenced this issue Apr 30, 2022
@cbracken
WinUWP: Remove WinUWP sources, targets
1f62d4a 
This removes:
* The Windows UWP emebedder sources and targets
* UWP-specific build targets
* UWP-specific code behind WINUWP #ifdefs
* UWP-specific TODOs.
* uwptool.exe sources and targets used for installing, uninstalling, and
  launching UWP apps.

This is a straight removal patch, and does not land any refactorings
made possible by removal of UWP support. Those patches will land in
followup refactorings.

Issue: flutter/flutter#102172
@cbracken cbracken mentioned this issue Apr 30, 2022
Merged
8 tasks
cbracken added a commit to cbracken/flutter_engine that referenced this issue Apr 30, 2022
@cbracken
WinUWP: Remove WinUWP sources, targets
2065c5b 
This removes:
* The Windows UWP emebedder sources and targets
* UWP-specific build targets
* UWP-specific code behind WINUWP #ifdefs
* UWP-specific TODOs.
* uwptool.exe sources and targets used for installing, uninstalling, and
  launching UWP apps.

This is a straight removal patch, and does not land any refactorings
made possible by removal of UWP support. Those patches will land in
followup refactorings.

Issue: flutter/flutter#102172
cbracken added a commit to flutter/engine that referenced this issue Apr 30, 2022
@cbracken
WinUWP: Remove WinUWP sources, targets (#33019)
433de86 
This removes:
* The Windows UWP emebedder sources and targets
* UWP-specific build targets
* UWP-specific code behind WINUWP #ifdefs
* UWP-specific TODOs.
* uwptool.exe sources and targets used for installing, uninstalling, and
  launching UWP apps.

This is a straight removal patch, and does not land any refactorings
made possible by removal of UWP support. Those patches will land in
followup refactorings.

Tool support was removed in:
flutter/flutter#102174

The CI target was removed in:
#33012

The Recipe was removed in:
https://flutter-review.googlesource.com/c/recipes/+/29500

GN build support was removed in:
#33016

Issue: flutter/flutter#102172
cbracken added a commit to cbracken/flutter_engine that referenced this issue Apr 30, 2022
@cbracken
Win: Remove WinRT headers, Windows SDK, cppwinrt
1252472 
WinRT was only ever used by the Windows UWP embedder since the main
Windows embedder supports compatibility with Windows 7 and WinRT
requires a Windows SDK target version of at least 10.0.17134.0 (Windows
10, version 1803).

When, at some point, we drop support for versions of Windows earlier
than Windows 10, we'll almost certainly want to resurrect this and start
using WinRT in the main Windows embedder.

The Windows UWP embedder was removed in:
flutter#33019

Issue: flutter/flutter#102172
@cbracken cbracken mentioned this issue Apr 30, 2022
Merged
8 tasks
cbracken added a commit to cbracken/flutter_engine that referenced this issue Apr 30, 2022
@cbracken
Win: Remove WinRT headers, Windows SDK, cppwinrt
e366258 
WinRT was only ever used by the Windows UWP embedder since the main
Windows embedder supports compatibility with Windows 7 and WinRT
requires a Windows SDK target version of at least 10.0.17134.0 (Windows
10, version 1803).

When, at some point, we drop support for versions of Windows earlier
than Windows 10, we'll almost certainly want to resurrect this and start
using WinRT in the main Windows embedder.

The Windows UWP embedder was removed in:
flutter#33019

Issue: flutter/flutter#102172
cbracken added a commit to cbracken/flutter_engine that referenced this issue Apr 30, 2022
@cbracken
Win: Remove WinRT headers, Windows SDK, cppwinrt
3b5fd06 
WinRT was only ever used by the Windows UWP embedder since the main
Windows embedder supports compatibility with Windows 7 and WinRT
requires a Windows SDK target version of at least 10.0.17134.0 (Windows
10, version 1803).

When, at some point, we drop support for versions of Windows earlier
than Windows 10, we'll almost certainly want to resurrect this and start
using WinRT in the main Windows embedder.

The Windows UWP embedder was removed in:
flutter#33019

Issue: flutter/flutter#102172
cbracken added a commit to cbracken/flutter_engine that referenced this issue Apr 30, 2022
@cbracken
WIP: Remove get_key_state and map_vk_to_scan
7fa92ab 
These are both injected into FlutterWindowsView because UWP didn't have
an implementation but Win32 did and we didn't want to #ifdef things in
the handler.

This is a partial (and broken) attempt at removing the first of these
two parameters and inlining the code directly into
KeyboardKeyEmbedderHander constructor.  The downside is we do actually
use this for injecting a fake into KeyboardKeyEmbedderHandler that we
can then use in unit tests.

Issue: flutter/flutter#102172
cbracken added a commit to cbracken/flutter_buildroot that referenced this issue Apr 30, 2022
@cbracken
Win: Remove generate_winrt_headers.py
8fb65af 
This removes a script that was used to generate C++ WinRT headers using
cppwinrt. All uses of these headers was removed with the removal of the
UWP embedder in:
flutter/engine#33019

and removal of the gclient hook in:
flutter/engine#33030

Issue: flutter/flutter#102172
@cbracken cbracken mentioned this issue Apr 30, 2022
Merged
8 tasks
cbracken added a commit to flutter/buildroot that referenced this issue Apr 30, 2022
@cbracken
Win: Remove generate_winrt_headers.py (#568)
63f03c8 
This removes a script that was used to generate C++ WinRT headers using
cppwinrt. All uses of these headers was removed with the removal of the
UWP embedder in:
flutter/engine#33019

and removal of the gclient hook in:
flutter/engine#33030

Issue: flutter/flutter#102172
cbracken added a commit to flutter/engine that referenced this issue Apr 30, 2022
@cbracken
Win: Remove WinRT headers, Windows SDK, cppwinrt (#33030)
4e3eabd 
WinRT was only ever used by the Windows UWP embedder since the main
Windows embedder supports compatibility with Windows 7 and WinRT
requires a Windows SDK target version of at least 10.0.17134.0 (Windows
10, version 1803).

When, at some point, we drop support for versions of Windows earlier
than Windows 10, we'll almost certainly want to resurrect this and start
using WinRT in the main Windows embedder.

The Windows UWP embedder was removed in:
#33019

Issue: flutter/flutter#102172
@cbracken cbracken mentioned this issue Apr 30, 2022
Merged
8 tasks
cbracken added a commit to flutter/engine that referenced this issue Apr 30, 2022
@cbracken
Roll buildroot to 63f03c8 (#33031)
29a6bec 
This includes:
* Win: Remove generate_winrt_headers.py (flutter/buildroot#568)

Issue: flutter/flutter#102172
@cbracken
Copy link
Member Author

At this point I'm going to call this done. There are further cleanups that this enables, but the UWP embedder, tooling, and build targets have been removed.

@jnschulze jnschulze mentioned this issue May 7, 2022
Closed
@moko256 moko256 mentioned this issue May 12, 2022
Closed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
@cbracken cbracken moved this to Done in Flutter Desktop May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cbracken cbracken

Labels
a: desktop Running on desktop c: tech-debt Technical debt, code quality, testing, etc. P2 Important issues not at the top of the work list platform-windows Building on or for Windows specifically
Projects
Flutter Desktop
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cbracken