Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update 24hr-clock TimePicker to use 2 rings as per latest Material Design native Android implementation #108598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jongkb opened this issue Jul 29, 2022 · 8 comments
Closed

Update 24hr-clock TimePicker to use 2 rings as per latest Material Design native Android implementation #108598

jongkb opened this issue Jul 29, 2022 · 8 comments
Labels
c: proposal A detailed proposal for a change to Flutter f: date/time picker Date or time picker widgets f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds

Comments

@jongkb
Copy link

jongkb commented Jul 29, 2022

Use case

As mentioned in #65730, there is a usability issue with the single-ring 24hr-clock TimePicker implementation. However, it was noted back then that Flutter follows the Material Design native Android Time Picker implementation which uses the single-ring design. See #65730 (comment)

In the latest Material Design native Android 24hr-clock Time Picker implementation, the single-ring implementation is now replaced with the more usable 2-ring design as referenced in the closed issue in material-components/material-components-android#1450 (comment)

Proposal

Replace Flutter's single-ring 24hr-clock TimePicker with the two-ring design—consistent with the latest Material Design Time Picker in native Android.
@exaby73 exaby73 added the in triage Presently being triaged by the triage team label Jul 29, 2022
@exaby73
Copy link
Member

exaby73 commented Jul 29, 2022

Hello @jongkb. Thank you for submitting this request. Looks like a valid one to me. I am labeling the issue to get some more insights from the team.

@exaby73 exaby73 added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: date/time picker Date or time picker widgets c: proposal A detailed proposal for a change to Flutter and removed in triage Presently being triaged by the triage team labels Jul 29, 2022
@HansMuller
Copy link
Contributor

This is a valid request and will be addressed as part of #108598. We still don't have a final Material 3 spec from the Material Design team for the time and date picker components.

CC @guidezpl

@lisovyk
Copy link

lisovyk commented Jan 20, 2023 •
edited
Loading

Hi guys, any timeline on this? As far as I can see it was implemented months ago in Material Design
@HansMuller
@exaby73

@guidezpl
Copy link
Member

Looping in @TahaTesser, who recently closed #101480.

@guidezpl guidezpl moved this to 🗺 Planned in Material 3 Feb 1, 2023
@stefan01 stefan01 mentioned this issue Mar 7, 2023
Closed
@TahaTesser
Copy link
Member

TahaTesser commented Apr 21, 2023 •
edited
Loading

Hi @jongkb and everyone

I can see the time picker in 24 hours matches the specs on master

Specs Flutter

@TahaTesser TahaTesser added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 21, 2023
@lisovyk
Copy link

lisovyk commented Apr 23, 2023

seems like we need input from @jongkb ? Looks awesome to me, can't wait for it to be released.

@github-actions
Copy link

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now.
If you find this problem please file a new issue with the same description, what happens, logs and the output of 'flutter doctor -v'. All system setups can be slightly different so it's always better to open new issues and reference the related ones.
Thanks for your contribution.

@github-project-automation github-project-automation bot moved this from 🗺 Planned to ✅ Done in Material 3 May 12, 2023
@guidezpl guidezpl mentioned this issue May 15, 2023
Closed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: proposal A detailed proposal for a change to Flutter f: date/time picker Date or time picker widgets f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds
Projects
No open projects
Material 3
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jongkb @HansMuller @guidezpl @lisovyk @TahaTesser @exaby73