Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow enabling custom-devices feature on all channels by default #108787

Open
@ardera

Description

@ardera

Currently enabling the custom-devices feature will only take effect on master channel:

const Feature flutterCustomDevicesFeature = Feature(
name: 'Early support for custom device types',
configSetting: 'enable-custom-devices',
environmentOverride: 'FLUTTER_CUSTOM_DEVICES',
master: FeatureChannelSetting(
available: true,
),
);

While I can understand this is to make sure people don't forget it's not a "stable" feature, it's leading to a lot of problems for the users:

The users are often users of custom embedders, like ivi-homescreen, the sony embedder or flutter-pi. Actually toyota seems to be using it quite a lot. In a custom-embedder scenario, you're often using custom engine builds. And because building the flutter engine is a bit resource-intensive, most people are only doing it for stable:

So most people actually want to use custom-devices with the stable channel, which the SDK doesn't allow though. This requires weird workarounds, like going into the SDK dir and checking out the stable SDK commit directly, or checking out the remote branch (origin/stable).

Basically everytime I introduce the feature to someone I have to tell them to use the workaround. Toyota has a script lying around that does nothing else but patch the SDK sources to make it possible to enable the feature on stable.

I'd like to propose we change that and allow the feature to be enabled on any channel. If you're worried that people perceive it as a "stable" feature, we can add some messages like "(this feature is in alpha right now!)" when enabling it. Or we can just say it's stable now

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: proposalA detailed proposal for a change to Flutterteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-toolTriaged by Flutter Tool team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions