Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CP] Enable tooling custom device support on beta and stable channel #110029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zanderso opened this issue Aug 22, 2022 · 5 comments
Closed

[CP] Enable tooling custom device support on beta and stable channel #110029

zanderso opened this issue Aug 22, 2022 · 5 comments
Labels
cp: approved Approved cherry-pick request

Comments

@zanderso
Copy link
Member

issue_link

#108787

Commit Hash

bd6b5ce

Target

beta

pr_link

#109959

Impacted Users

Customers with custom embedders

Impact Description

Customers with custom embedders of the Engine are unable to use tooling support for custom devices on beta and stable channels. Wanting to cherry-pick this to avoid waiting until EOY for this to be available under the regular schedule.

Workaround

Using master channel, but that is a big hassle.

Risk

low

Test Coverage

yes

Validation Steps

The feature flag works on beta and stable channels.
@zanderso zanderso added the cp: review Cherry-picks in the review queue label Aug 22, 2022
@zanderso
Copy link
Member Author

@itsjustkevin

@zanderso zanderso mentioned this issue Aug 24, 2022
Merged
8 tasks
@itsjustkevin
Copy link
Contributor

@christopherfujino can you take a second look at this and the associated pr?

@christopherfujino
Copy link
Contributor

@christopherfujino can you take a second look at this and the associated pr?

👍

@christopherfujino
Copy link
Contributor

request and PR approved

@itsjustkevin itsjustkevin added cp: approved Approved cherry-pick request and removed cp: review Cherry-picks in the review queue labels Aug 25, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cp: approved Approved cherry-pick request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zanderso @christopherfujino @itsjustkevin