Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[flutter_tools] Enable custom devices on all channels (#109953) #109959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2022
Merged

[flutter_tools] Enable custom devices on all channels (#109953) #109959

merged 2 commits into from
Aug 26, 2022

Conversation

zanderso
Copy link
Member

This is a cherry-pick of #109953 for #108787

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-3.2-candidate.5 to master August 21, 2022 19:33
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-3.2-candidate.5. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot added engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 21, 2022
@zanderso zanderso changed the base branch from master to flutter-3.2-candidate.5 August 21, 2022 19:34
@zanderso zanderso mentioned this pull request Aug 22, 2022
Closed
@goderbauer goderbauer removed the framework flutter/packages/flutter repository. See also f: labels. label Aug 23, 2022
christopherfujino
christopherfujino approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2022
@zanderso
Copy link
Member Author

@keyonghan The autosubmit label seems not to have worked here.

@keyonghan
Copy link
Contributor

@keyonghan The autosubmit label seems not to have worked here.

Auto submit is not supporting release branches as of now. So this WAI.
Related bug: #110023

@christopherfujino
Copy link
Contributor

@keyonghan The autosubmit label seems not to have worked here.

Auto submit is not supporting release branches as of now. So this WAI. Related bug: #110023

Could we catch this and have autosubmit comment?

@zanderso
Copy link
Member Author

I think @itsjustkevin meant this to land, so I'm going to go ahead and click the button.

@zanderso zanderso merged commit db73554 into flutter:flutter-3.2-candidate.5 Aug 26, 2022
@zanderso zanderso deleted the cp-custom-device-flag branch August 26, 2022 20:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
db735548f [flutter_tools] Enable custom devices on all channels (#109…
17e7e2a 
…953) (flutter/flutter#109959)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
db735548f [flutter_tools] Enable custom devices on all channels (#109…
46d646b 
…953) (flutter/flutter#109959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App engine flutter/engine repository. See also e: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zanderso @keyonghan @christopherfujino @goderbauer @itsjustkevin