Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate WidgetController semantics methods #112670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pdblasi-google opened this issue Sep 29, 2022 · 0 comments
Open

Deprecate WidgetController semantics methods #112670

pdblasi-google opened this issue Sep 29, 2022 · 0 comments
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@pdblasi-google
Copy link
Contributor

Followup to #107866.

Use case

As part of #107866, we're starting to place semantics related methods into a SemanticsController class for maintainability and read/write-ability.

Proposal

  • Deprecate semantics related methods on WidgetController
  • Create data-driven fixes for any deprecated methods
  • Remove references to deprecated methods in the flutter repos
@pdblasi-google pdblasi-google added a: tests "flutter test", flutter_test, or one of our tests P2 Important issues not at the top of the work list labels Sep 29, 2022
@pdblasi-google pdblasi-google self-assigned this Sep 29, 2022
@pdblasi-google pdblasi-google mentioned this issue Oct 7, 2022
Merged
8 tasks
pdblasi-google added a commit to pdblasi-google/flutter that referenced this issue Oct 20, 2022
@pdblasi-google
Added support for simulating accessibility traversal to allow tests f…
fb91ae7 
…or order of accessibility reading.

* `SemanticsController` has been added to `WidgetController` for grouping semantics related testing needs
* `getSemantics` has been replaced with `SemanticsController.find` and will be deprecated in flutter#112670
* Further functionality will be added to `SemanticsController` during flutter#112413
@darshankawar darshankawar added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: proposal A detailed proposal for a change to Flutter labels Jan 24, 2023
@flutter-triage-bot flutter-triage-bot bot added team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Jul 8, 2023
@pdblasi-google pdblasi-google removed their assignment Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darshankawar @pdblasi-google