[Windows] [Multi-window] Share internal plugins #115611
Labels
a: desktop
Running on desktop
a: multi window
Issues related to multi window support
P3
Issues that are less important to the Flutter project
platform-windows
Building on or for Windows specifically
team-windows
Owned by the Windows platform team
Comments
This was referenced Nov 21, 2022
8 tasks
This was referenced Dec 29, 2022
This was referenced Jan 27, 2023
This was referenced Feb 3, 2023
|
The Windows embedder's plugins are now shared by the engine. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
|
Reopening as the text input plugin's initialization depends on view creation. |
This was referenced Nov 8, 2023
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this issue
Nov 9, 2023
Currently the keyboard tests use global state to track key calls. As a result, a good test can fail if a bad test leaves key calls in the global state. This removes the global state and ensures each test is isolated. Preparation for flutter/flutter#115611 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this issue
Nov 30, 2023
Currently the text input plugin is strongly tied to a single view. This change makes the text input plugin tied to the engine in preparation for multi-view world. Part of flutter/flutter#115611 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
|
Addressed by flutter/engine#51758 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Background
On Windows, several internal plugins are owned by the view (
FlutterWindowsView). These plugins are intended to be singletons and should be shared in a multi-view world.Solution
Share internal plugins across views by making them owned by the engine.
The text was updated successfully, but these errors were encountered: