Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[web] Update needed for the updated directory structure in the Dart SDK #118119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nshahan opened this issue Jan 6, 2023 · 3 comments · Fixed by #118120
Closed

[web] Update needed for the updated directory structure in the Dart SDK #118119

nshahan opened this issue Jan 6, 2023 · 3 comments · Fixed by #118120
Labels
platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Comments

@nshahan
Copy link
Contributor

nshahan commented Jan 6, 2023 •
edited
Loading

For Dart 3.0 I am cleaning up the assets packaged in the Dart SDK for the development web compiler. I'm deleting files that are unused and cleaning up the extraneous sub-directories dart-lang/sdk#50700.

As far as I can tell the only issue this will cause is when require.js is read from the Dart SDK.

flutter/packages/flutter_tools/lib/src/isolated/devfs_web.dart

Lines 929 to 936 in db1c3e2

final File requireJS = globals.fs.file(globals.fs.path.join(
globals.artifacts!.getArtifactPath(Artifact.engineDartSdkPath, platform: TargetPlatform.web_javascript),
'lib',
'dev_compiler',
'kernel',
'amd',
'require.js',
));

The fix will be very simple and I have a PR prepared.
#118120

I'd like guidance in how to land properly or whom to notify since it will break after I land my change in the Dart SDK and it gets rolled into engine, and then into flutter.

A second set of eyes looking at the issue linked above to identify any other potential problems would be helpful as well.
@nshahan nshahan mentioned this issue Jan 6, 2023
Merged
@huycozy huycozy added in triage Presently being triaged by the triage team tool Affects the "flutter" command-line tool. See also t: labels. platform-web Web applications specifically and removed in triage Presently being triaged by the triage team labels Jan 9, 2023
@kevmoo
Copy link
Contributor

kevmoo commented Jan 9, 2023

I'm guessing we'll just need to have a world where both exist – one falling back to the other – until we do the cross over.

@hterkelsen @yjbanov ?

@nshahan
Copy link
Contributor Author

nshahan commented Jan 9, 2023

Yes, I'm working on a change that will support either location and then a followup to remove the old once my SDK change rolls all the way through.

nshahan added a commit to nshahan/flutter that referenced this issue Jan 18, 2023
@nshahan
Fix path for require.js
e203a31 
Matches new location in the Dart SDK.
https://dart-review.googlesource.com/c/sdk/+/275482

Includes fall back logic so the old file location will continue to be used
until the new location change lands. Then we can remove the logic and only
use the new location in a future change.

Issue: flutter#118119
@nshahan nshahan mentioned this issue Jan 18, 2023
Merged
iskakaushik pushed a commit that referenced this issue Jan 18, 2023
@nshahan
Fix path for require.js (#118722)
bb8b96a 
Matches new location in the Dart SDK.
https://dart-review.googlesource.com/c/sdk/+/275482

Includes fall back logic so the old file location will continue to be used
until the new location change lands. Then we can remove the logic and only
use the new location in a future change.

Issue: #118119
gspencergoog pushed a commit to gspencergoog/flutter that referenced this issue Jan 19, 2023
@nshahan @gspencergoog
Fix path for require.js (flutter#118722)
24d17cb 
Matches new location in the Dart SDK.
https://dart-review.googlesource.com/c/sdk/+/275482

Includes fall back logic so the old file location will continue to be used
until the new location change lands. Then we can remove the logic and only
use the new location in a future change.

Issue: flutter#118119
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix path for require.js nshahan/flutter
3 participants
@kevmoo @nshahan @huycozy