Clean up duplicated code between FML and third_party/accessibility #118811
Labels
a: accessibility
Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)
a: desktop
Running on desktop
c: tech-debt
Technical debt, code quality, testing, etc.
engine
flutter/engine repository. See also e: labels.
P2
Important issues not at the top of the work list
platform-mac
Building on or for macOS specifically
platform-windows
Building on or for Windows specifically
team-macos
Owned by the macOS platform team
triaged-macos
Triaged by the macOS platform team
Comments
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Jan 19, 2023
In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811
8 tasks
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Jan 19, 2023
In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Jan 19, 2023
In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Jan 19, 2023
In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Jan 19, 2023
In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Jan 19, 2023
In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this issue
Jan 19, 2023
* Extract WideToUTF16String/UTF16StringToWide to FML In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811 * Migrate UTF16ToWide as well
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this issue
Jan 20, 2023
In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811
8 tasks
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this issue
Jan 25, 2023
* Extract WideToUTF16String/UTF16StringToWide to FML In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811 * Migrate UTF16ToWide as well
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
//third_party/accessibility started as a fork of Chromium's accessibility code, but has diverged significantly enough that it's unlikely we'll ever merge updates from upstream. Long-term, we should probably consider a more thorough revamp into a portable, shared, flutter accessibility library but for the time being, we should eliminate any low-hanging fruit in terms of duplication.
Candidates:
The text was updated successfully, but these errors were encountered: