-
Notifications
You must be signed in to change notification settings - Fork 28.5k
Documentation on gathering engine treemaps is out-of-date. #136011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
From the LUCI build https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/399194/overview I can find the link Which we could use to update the wiki page, but I don't know why the |
This issue is marked P1 but has had no recent status updates. The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub. Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks! |
From the commit message:
We actually upload to two locations. First, for the subtest: Running the following only lists one folder (the UUID).
And then a second time at the end, which includes all builders for the sha:
Sadly, this is a new UUID rather than the first one (999fceb0-1148-4ab2-94c6-da78813f228d). Potential solution: Add a field to the task that would include two pieces of information: "android_release_arm64" & "sizes" and pull those out in builder.py So "tests": [
{
"name": "Generate treemap for android_release_arm64",
"language": "bash",
"script": "flutter/ci/binary_size_treemap.sh",
"parameters": [
"../../src/out/ci/android_release_arm64/libflutter.so",
"${FLUTTER_LOGS_DIR}"
],
"upload_logs": {"name": "android_release_arm64", "key": "sizes"}
}
] |
fixes: #136011 Logs should now be locate: * gs://flutter_logs/flutter/_SHA_/android_release_arm64/sizes/ * https://storage.googleapis.com/flutter_logs/flutter/_SHA_/android_release_arm64/sizes/index.html
) fixes: flutter#136011 Logs should now be locate: * gs://flutter_logs/flutter/_SHA_/android_release_arm64/sizes/ * https://storage.googleapis.com/flutter_logs/flutter/_SHA_/android_release_arm64/sizes/index.html
https://github.com/flutter/flutter/wiki/Engine-disk-footprint#treemaps points to guidance on how to generate treemaps of the Flutter Engine. This used to work at some point. See https://storage.googleapis.com/flutter_infra_release/flutter/12def739b1f63ccaf5b859714d9f552e9e6fe348/android-arm64-release/sizes/index.html. However, it no longer works for recent engine commits. See https://storage.googleapis.com/flutter_infra_release/flutter/4d1f8ff52903dc94574397228597488ec8c089d7/android-arm64-release/sizes/index.html (the SHA is the latest engine.version in framework as of this writing).
The text was updated successfully, but these errors were encountered: