Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Documentation on gathering engine treemaps is out-of-date. #136011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chinmaygarde opened this issue Oct 5, 2023 · 4 comments · Fixed by #168349
Closed

Documentation on gathering engine treemaps is out-of-date. #136011

chinmaygarde opened this issue Oct 5, 2023 · 4 comments · Fixed by #168349
Assignees
Labels
d: wiki Flutter or engine wikis P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@chinmaygarde
Copy link
Member

https://github.com/flutter/flutter/wiki/Engine-disk-footprint#treemaps points to guidance on how to generate treemaps of the Flutter Engine. This used to work at some point. See https://storage.googleapis.com/flutter_infra_release/flutter/12def739b1f63ccaf5b859714d9f552e9e6fe348/android-arm64-release/sizes/index.html. However, it no longer works for recent engine commits. See https://storage.googleapis.com/flutter_infra_release/flutter/4d1f8ff52903dc94574397228597488ec8c089d7/android-arm64-release/sizes/index.html (the SHA is the latest engine.version in framework as of this writing).

@chinmaygarde chinmaygarde added d: wiki Flutter or engine wikis team-engine Owned by Engine team labels Oct 5, 2023
@zanderso
Copy link
Member

zanderso commented Oct 6, 2023

From the LUCI build https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/399194/overview

I can find the link

https://storage.googleapis.com/flutter_logs/flutter/59b6b94e1a5168ddb77315df788a80fe0c094ecd/Generate%20treemap%20for%20android_release_arm64/ddca6da8-ee63-49c3-9b88-359456fb59e9/index.html

Which we could use to update the wiki page, but I don't know why the ddca6da8-ee63-49c3-9b88-359456fb59e9 component is there. @godofredoc do you know what that part is, or if we can get rid of it somehow so that we can go back to deriving the link from only the variant and commit hash?

@chinmaygarde chinmaygarde added P1 High-priority issues at the top of the work list triaged-engine Triaged by Engine team labels Oct 9, 2023
@flutter-triage-bot flutter-triage-bot bot removed the triaged-engine Triaged by Engine team label Feb 28, 2024
@flutter-triage-bot
Copy link

This issue is marked P1 but has had no recent status updates.

The P1 label indicates high-priority issues that are at the top of the work list. This is the highest priority level a bug can have if it isn't affecting a top-tier customer or breaking the build. Bugs marked P1 are generally actively being worked on unless the assignee is dealing with a P0 bug (or another P1 bug). Issues at this level should be resolved in a matter of months and should have monthly updates on GitHub.

Please consider where this bug really falls in our current priorities, and label it or assign it accordingly. This allows people to have a clearer picture of what work is actually planned. Thanks!

@chinmaygarde chinmaygarde added P2 Important issues not at the top of the work list and removed P1 High-priority issues at the top of the work list labels Feb 28, 2024
@jonahwilliams jonahwilliams added the triaged-engine Triaged by Engine team label Mar 4, 2024
@jtmcdole
Copy link
Member

jtmcdole commented May 5, 2025

https://storage.googleapis.com/flutter_logs/flutter/59b6b94e1a5168ddb77315df788a80fe0c094ecd/Generate%20treemap%20for%20android_release_arm64/ddca6da8-ee63-49c3-9b88-359456fb59e9/index.html

Which we could use to update the wiki page, but I don't know why the ddca6da8-ee63-49c3-9b88-359456fb59e9 component is there. @godofredoc do you know what that part is, or if we can get rid of it somehow so that we can go back to deriving the link from only the variant and commit hash?

From the commit message:

We also changed the logs destination to include task name an a uuid to ensure logs are not clashing.

We actually upload to two locations. First, for the subtest:

Running the following only lists one folder (the UUID).

$ gsutil ls gs://flutter_logs/flutter/78a2a3fa675572fe55b2aa47e2ff1317baf30d03/Generate\ treemap\ for\ android_release_arm64
gs://flutter_logs/flutter/78a2a3fa675572fe55b2aa47e2ff1317baf30d03/Generate treemap for android_release_arm64/999fceb0-1148-4ab2-94c6-da78813f228d/

And then a second time at the end, which includes all builders for the sha:

gsutil ls gs://flutter_logs/engine/78a2a3fa675572fe55b2aa47e2ff1317baf30d03/builder | wc -l
     191

Sadly, this is a new UUID rather than the first one (999fceb0-1148-4ab2-94c6-da78813f228d).

Potential solution: Add a field to the task that would include two pieces of information: "android_release_arm64" & "sizes" and pull those out in builder.py run_tests and pass them in as the task and new "key" field to upload_logs.

So linux_android_aot_engine.json would look like:

            "tests": [
                {
                    "name": "Generate treemap for android_release_arm64",
                    "language": "bash",
                    "script": "flutter/ci/binary_size_treemap.sh",
                    "parameters": [
                        "../../src/out/ci/android_release_arm64/libflutter.so",
                        "${FLUTTER_LOGS_DIR}"
                    ],
                   "upload_logs": {"name": "android_release_arm64", "key": "sizes"}
                }
            ]

@jtmcdole jtmcdole self-assigned this May 5, 2025
@jtmcdole
Copy link
Member

jtmcdole commented May 5, 2025

jtmcdole added a commit to jtmcdole/flutter that referenced this issue May 5, 2025
github-merge-queue bot pushed a commit that referenced this issue May 6, 2025
mboetger pushed a commit to mboetger/flutter that referenced this issue May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d: wiki Flutter or engine wikis P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants